* [Buildroot] [PATCH v2] package/gcc: map debug prefix when reproducible
@ 2023-02-07 19:58 John Keeping
2023-02-07 22:47 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2023-02-07 19:58 UTC (permalink / raw)
To: buildroot
Cc: Romain Naour, John Keeping, Giulio Benetti, Thomas Petazzoni,
Yann E. MORIN
When building with BR2_REPRODUCIBLE the toolchain wrapper passes
-fdebug-prefix-map for all packages that are built. But this doesn't
affect the target libraries (like libgcc) built by GCC's build system.
GCC 4.3 added a configure option to set the debug prefix map for these
libraries, which is used here to avoid encoding potentially
non-reproducible build paths into the debug data.
Signed-off-by: John Keeping <john@metanate.com>
---
Changes since v1:
- Add the option to GCC common config, not just gcc-final
package/gcc/gcc.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
index ec6f3b550a..6dfd93f2a4 100644
--- a/package/gcc/gcc.mk
+++ b/package/gcc/gcc.mk
@@ -84,6 +84,10 @@ HOST_GCC_COMMON_CONF_OPTS = \
--with-bugurl="http://bugs.buildroot.net/" \
--without-zstd
+ifeq ($(BR2_REPRODUCIBLE),y)
+HOST_GCC_COMMON_CONF_OPTS += --with-debug-prefix-map=$(BASE_DIR)=buildroot
+endif
+
# Don't build documentation. It takes up extra space / build time,
# and sometimes needs specific makeinfo versions to work
HOST_GCC_COMMON_CONF_ENV = \
--
2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v2] package/gcc: map debug prefix when reproducible
2023-02-07 19:58 [Buildroot] [PATCH v2] package/gcc: map debug prefix when reproducible John Keeping
@ 2023-02-07 22:47 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2023-02-07 22:47 UTC (permalink / raw)
To: John Keeping; +Cc: Romain Naour, Giulio Benetti, Thomas Petazzoni, buildroot
John, All,
On 2023-02-07 19:58 +0000, John Keeping spake thusly:
> When building with BR2_REPRODUCIBLE the toolchain wrapper passes
> -fdebug-prefix-map for all packages that are built. But this doesn't
> affect the target libraries (like libgcc) built by GCC's build system.
>
> GCC 4.3 added a configure option to set the debug prefix map for these
> libraries, which is used here to avoid encoding potentially
> non-reproducible build paths into the debug data.
>
> Signed-off-by: John Keeping <john@metanate.com>
After burnng through ~80% of my battery testing this: applied to
master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes since v1:
> - Add the option to GCC common config, not just gcc-final
>
> package/gcc/gcc.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
> index ec6f3b550a..6dfd93f2a4 100644
> --- a/package/gcc/gcc.mk
> +++ b/package/gcc/gcc.mk
> @@ -84,6 +84,10 @@ HOST_GCC_COMMON_CONF_OPTS = \
> --with-bugurl="http://bugs.buildroot.net/" \
> --without-zstd
>
> +ifeq ($(BR2_REPRODUCIBLE),y)
> +HOST_GCC_COMMON_CONF_OPTS += --with-debug-prefix-map=$(BASE_DIR)=buildroot
> +endif
> +
> # Don't build documentation. It takes up extra space / build time,
> # and sometimes needs specific makeinfo versions to work
> HOST_GCC_COMMON_CONF_ENV = \
> --
> 2.39.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-07 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-07 19:58 [Buildroot] [PATCH v2] package/gcc: map debug prefix when reproducible John Keeping
2023-02-07 22:47 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox