From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: Matt Flax <flatmax@flatmax.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v6] package/gtkiostream: new package
Date: Wed, 8 Feb 2023 11:53:54 +0100 [thread overview]
Message-ID: <20230208115354.7437af06@windsurf> (raw)
In-Reply-To: <20230208100704.68093-1-angelo@amarulasolutions.com>
On Wed, 8 Feb 2023 11:07:04 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> diff --git a/package/gtkiostream/Config.in b/package/gtkiostream/Config.in
> new file mode 100644
> index 0000000000..58c22ecbcb
> --- /dev/null
> +++ b/package/gtkiostream/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_GTKIOSTREAM
> + bool "gtkiostream"
> + depends on BR2_INSTALL_LIBSTDCPP # eigen
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + select BR2_PACKAGE_EIGEN
> + select BR2_PACKAGE_FFTW
> + select BR2_PACKAGE_FFTW_DOUBLE
> + select BR2_PACKAGE_FFTW_SINGLE
> + help
> + This package provides many useful software engineering and
> + signal processing includes and linkable library.
> +
> + https://github.com/flatmax/gtkiostream
> +
> +comment "gtkiostream needs a toolchain w/ C++"
and threads.
> +GTKIOSTREAM_VERSION = v1.8.0
Should be 1.8.0
> +GTKIOSTREAM_SITE = $(call github,flatmax,gtkiostream,$(GTKIOSTREAM_VERSION))
And should be:
GTKIOSTREAM_SITE = $(call github,flatmax,gtkiostream,v$(GTKIOSTREAM_VERSION))
These issues can be fixed when applying, just noting them here as I
noticed them.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-08 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 10:07 [Buildroot] [PATCH v6] package/gtkiostream: new package Angelo Compagnucci
2023-02-08 10:53 ` Thomas Petazzoni via buildroot [this message]
2024-07-14 17:02 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208115354.7437af06@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo@amarulasolutions.com \
--cc=flatmax@flatmax.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox