Re: [Buildroot] [PATCH v6] package/gtkiostream: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Matt, Hello Angelo,

On Wed,  8 Feb 2023 11:07:04 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> From: Matt Flax <flatmax@flatmax.com>
> 
> This package provides many useful software engineering and signal
> processing libraries.
> 
> Signed-off-by: Matt Flax <flatmax@flatmax.com>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> v4:                             
> * Bumped to 1.8.0                                                
> * Added myself to DEVELOPERS                                     
> * Added dependency on octave when enable instead of use
>   --disable-octave configure option                                                                                               
> * Fixes from check-package                                                                                                        
> v5:                                                              
> * Fixed wrong syntax (Romain)                                    
> * Added optional dependency on sox (Matt) 
> v6:
> * Fixing fomatting (Thmos P.)
> * Adding optional flag for openmp
> * Adding patch to disable testing compilation:
>   build wasfailing for some incompatible linking option in one of the
>   tests. Tests are not useful for the buildroot usecase therefore they
>   are disabled.

I have finally merged this patch (yeah, sorry for the big delay!), with
quite a lot of changes:

- Made the patch upstreamable by adding a ./configure option, and
  actually submitted the patch upstream. Added the Upstream: tag
  pointing to the pull request

- Adding "threads" to the Config.in comment about dependencies

- Handling all optional dependencies, since they don't have any
  --disable-<foo> option.

See https://gitlab.com/buildroot.org/buildroot/-/commit/fab48302865e5c0c98d91b696bc90e75e38189bb
for the final commit.

I've seen upstream has a lot of commits on top of 1.8.0. It would be
nice for upstream (hint, hint!) to do a new release that includes all
those improvements, so that we can update the package in Buildroot.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot