[Buildroot] [PATCH] package/rtl8723ds: change CFLAGS approach

[Buildroot] [PATCH] package/rtl8723ds: change CFLAGS approach

[Giulio Benetti]

Instead of undefine endiannes CFLAGS let's change approach.
Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
involving the endianness to be set to little. This way we can set the
CFLAGS according to architecture with some default define like:
-DCONFIG_IOCTL_CFG80211
-DRTW_USE_CFG80211_STA_EVENT
-Wno-error

Suggested-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/rtl8723ds/rtl8723ds.mk | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/rtl8723ds/rtl8723ds.mk b/package/rtl8723ds/rtl8723ds.mk
index 7e27fa75ea..8a7674e5b6 100644
--- a/package/rtl8723ds/rtl8723ds.mk
+++ b/package/rtl8723ds/rtl8723ds.mk
@@ -8,12 +8,13 @@ RTL8723DS_VERSION = a638cc8639015b8b9390af3350fab0366b6c87e7
 RTL8723DS_SITE = $(call github,lwfinger,rtl8723ds,$(RTL8723DS_VERSION))
 RTL8723DS_LICENSE = GPL-2.0
 
-# Undefine the hardcoded CONFIG_LITTLE_ENDIAN
-RTL8723DS_USER_EXTRA_CLAGS = -UCONFIG_LITTLE_ENDIAN
-# Set endianness
-RTL8723DS_USER_EXTRA_CLAGS += -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN
+RTL8723DS_USER_EXTRA_CLAGS += -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \
+			      -DCONFIG_IOCTL_CFG80211 \
+			      -DRTW_USE_CFG80211_STA_EVENT \
+			      -Wno-error
 
 RTL8723DS_MODULE_MAKE_OPTS = \
+	CONFIG_PLATFORM_I386_PC=n \
 	CONFIG_RTL8723DS=m \
 	KVER=$(LINUX_VERSION_PROBED) \
 	KSRC=$(LINUX_DIR) \
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/rtl8723ds: change CFLAGS approach

[Thomas Petazzoni via buildroot]

On Tue, 13 Dec 2022 22:13:13 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Instead of undefine endiannes CFLAGS let's change approach.
> Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
> involving the endianness to be set to little. This way we can set the
> CFLAGS according to architecture with some default define like:
> -DCONFIG_IOCTL_CFG80211
> -DRTW_USE_CFG80211_STA_EVENT
> -Wno-error
> 
> Suggested-by: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/rtl8723ds/rtl8723ds.mk | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/rtl8723ds: change CFLAGS approach

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Tue, 13 Dec 2022 22:13:13 +0100
 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

 >> Instead of undefine endiannes CFLAGS let's change approach.
 >> Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
 >> involving the endianness to be set to little. This way we can set the
 >> CFLAGS according to architecture with some default define like:
 >> -DCONFIG_IOCTL_CFG80211
 >> -DRTW_USE_CFG80211_STA_EVENT
 >> -Wno-error
 >> 
 >> Suggested-by: Arnout Vandecappelle <arnout@mind.be>
 >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 >> ---
 >> package/rtl8723ds/rtl8723ds.mk | 9 +++++----
 >> 1 file changed, 5 insertions(+), 4 deletions(-)

 > Applied to master, thanks.

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot