[Buildroot] [PATCH 1/1] package/libiberty: bump version to 2.38

[Buildroot] [PATCH 1/1] package/libiberty: bump version to 2.38

[Akshay Bhat]

If the libiberty package is not the same version as the one packaged
with binutils AND if libiberty is installed before binutils, then the
below error is observed. Hence for now let us keep the versions in sync.

/usr/bin/ld: ../libiberty/libiberty.a(hashtab.o):(.data.rel.local+0x0): multiple definition of `htab_eq_pointer'

Signed-off-by: Akshay Bhat <nodeax@gmail.com>
---
 package/libiberty/libiberty.hash | 2 +-
 package/libiberty/libiberty.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
index 0dafcea520..74b2d89d31 100644
--- a/package/libiberty/libiberty.hash
+++ b/package/libiberty/libiberty.hash
@@ -1,5 +1,5 @@
 # From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
-sha512  d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724afa1e43bd0db45cfc9916b41519b67dfce03232aa4978704492a6994a  binutils-2.32.tar.xz
+sha512  8bf0b0d193c9c010e0518ee2b2e5a830898af206510992483b427477ed178396cd210235e85fd7bd99a96fc6d5eedbeccbd48317a10f752b7336ada8b2bb826d  binutils-2.38.tar.xz
 
 # Locally computed, same as binutils.hash
 sha256  56bdea73b6145ef6ac5259b3da390b981d840c24cb03b8e1cbc678de7ecfa18d  COPYING.LIB
diff --git a/package/libiberty/libiberty.mk b/package/libiberty/libiberty.mk
index 6235a8b956..e0e6987ad7 100644
--- a/package/libiberty/libiberty.mk
+++ b/package/libiberty/libiberty.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBIBERTY_VERSION = 2.32
+LIBIBERTY_VERSION = 2.38
 LIBIBERTY_SOURCE = binutils-$(LIBIBERTY_VERSION).tar.xz
 LIBIBERTY_SITE = $(BR2_GNU_MIRROR)/binutils
 HOST_LIBIBERTY_DL_SUBDIR = binutils
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libiberty: bump version to 2.38

[Thomas Petazzoni via buildroot]

Hello,

On Fri, 10 Feb 2023 10:02:22 -0800
Akshay Bhat <nodeax@gmail.com> wrote:

> If the libiberty package is not the same version as the one packaged
> with binutils AND if libiberty is installed before binutils, then the
> below error is observed. Hence for now let us keep the versions in sync.
> 
> /usr/bin/ld: ../libiberty/libiberty.a(hashtab.o):(.data.rel.local+0x0): multiple definition of `htab_eq_pointer'
> 
> Signed-off-by: Akshay Bhat <nodeax@gmail.com>

Thanks a lot for the fix. Is this fixing
http://autobuild.buildroot.net/results/eaf/eaf23ea0c8d7803e3768da40b7070d04801cd36f/build-end.log
perhaps?

One issue that I see is that the binutils version is configurable: we
support 2.37, 2.38, 2.39 and the special ARC version. Do we need to
make the libiberty version match with that?

Also, see the conversation starting at:

  https://lore.kernel.org/buildroot/3f3d266c-2f21-197c-29b7-fff3e230e97a@smile.fr/

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libiberty: bump version to 2.38

[Akshay Bhat]

Hi Thomas,

On Fri, Feb 10, 2023 at 2:13 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Thanks a lot for the fix. Is this fixing
> http://autobuild.buildroot.net/results/eaf/eaf23ea0c8d7803e3768da40b7070d04801cd36f/build-end.log
> perhaps?

Yes, that is the issue being fixed!

In my case, I enabled the partial initramfs feature. This resulted in
the below dependencies:
host-dracut -> host-prelink-cross -> host-libiberty

If host-libiberty gets built before host-binutils and the versions are
different (i.e. functions don't match up) then it results in the above
error.

>
> One issue that I see is that the binutils version is configurable: we
> support 2.37, 2.38, 2.39 and the special ARC version. Do we need to
> make the libiberty version match with that?
>

FWIW, the 2.38 version of libiberty does not result in build errors
with either 2.37 or 2.39 version of binutils. Happened to get lucky
because the libiberty related function defs are largely same-ish
between those versions. Obviously this can break with the next version
of binutils, so a long term fix is needed.

Not sure about the special ARC version, I did not test that case.

> Also, see the conversation starting at:
>
>   https://lore.kernel.org/buildroot/3f3d266c-2f21-197c-29b7-fff3e230e97a@smile.fr/
>

Thanks, hadn't seen that post before sending the patch and it looks
like this package has had some history! I agree, whatever decision
comes from that discussion should be the long term fix.

Thanks,
Akshay
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot