From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: David Bachelart <david.bachelart@bbright.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar
Date: Sun, 19 Feb 2023 23:05:10 +0100 [thread overview]
Message-ID: <20230219230510.4b29d5be@windsurf> (raw)
In-Reply-To: <20230219161453.87903-1-fontaine.fabrice@gmail.com>
On Sun, 19 Feb 2023 17:14:53 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> For an unknown reason, wchar_t is incorrectly detected with uclibc
> resulting in the following build failure:
>
> In file included from igetevent.c:136:
> imb_api.h:150:5: error: unknown type name 'wchar_t'
> 150 | wchar_t *Buffer;
> | ^~~~~~~
>
> The build failure can be reproduced even when reverting bump to version
> 3.1.8.
>
> Fixes:
> - http://autobuild.buildroot.org/results/e9ff3bd08e106dc834968bf5e4296ce8299027f8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/ipmiutil/ipmiutil.mk | 1 +
> 1 file changed, 1 insertion(+)
I think the problem is that uClibc-ng defines the wchar_t type even if
wchar support is disabled. I believe if the AC_CHECK_TYPES() check in
ipmiutil ensured that <wchar.h> was included, the detection would work
correctly, as wchar.h contains a #error when wchar support is disabled.
Anyway, in the mean time, what you proposed looks fine to me, so:
applied!
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-19 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 16:14 [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar Fabrice Fontaine
2023-02-19 22:05 ` Thomas Petazzoni via buildroot [this message]
2023-03-04 19:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230219230510.4b29d5be@windsurf \
--to=buildroot@buildroot.org \
--cc=david.bachelart@bbright.com \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox