[Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar

[Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar

[Fabrice Fontaine]

For an unknown reason, wchar_t is incorrectly detected with uclibc
resulting in the following build failure:

In file included from igetevent.c:136:
imb_api.h:150:5: error: unknown type name 'wchar_t'
  150 |     wchar_t *Buffer;
      |     ^~~~~~~

The build failure can be reproduced even when reverting bump to version
3.1.8.

Fixes:
 - http://autobuild.buildroot.org/results/e9ff3bd08e106dc834968bf5e4296ce8299027f8

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ipmiutil/ipmiutil.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ipmiutil/ipmiutil.mk b/package/ipmiutil/ipmiutil.mk
index ad9fbfc24c..b48eaa7cb2 100644
--- a/package/ipmiutil/ipmiutil.mk
+++ b/package/ipmiutil/ipmiutil.mk
@@ -10,6 +10,7 @@ IPMIUTIL_LICENSE = BSD-3-Clause
 IPMIUTIL_LICENSE_FILES = COPYING
 
 IPMIUTIL_MAKE = $(MAKE1)
+IPMIUTIL_CONF_ENV = ac_cv_type_wchar_t=$(if $(BR2_USE_WCHAR),yes,no)
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 # tests against distro libcrypto so it might get a false positive when
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar

[Thomas Petazzoni via buildroot]

On Sun, 19 Feb 2023 17:14:53 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> For an unknown reason, wchar_t is incorrectly detected with uclibc
> resulting in the following build failure:
> 
> In file included from igetevent.c:136:
> imb_api.h:150:5: error: unknown type name 'wchar_t'
>   150 |     wchar_t *Buffer;
>       |     ^~~~~~~
> 
> The build failure can be reproduced even when reverting bump to version
> 3.1.8.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e9ff3bd08e106dc834968bf5e4296ce8299027f8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ipmiutil/ipmiutil.mk | 1 +
>  1 file changed, 1 insertion(+)

I think the problem is that uClibc-ng defines the wchar_t type even if
wchar support is disabled. I believe if the AC_CHECK_TYPES() check in
ipmiutil ensured that <wchar.h> was included, the detection would work
correctly, as wchar.h contains a #error when wchar support is disabled.

Anyway, in the mean time, what you proposed looks fine to me, so:
applied!

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > For an unknown reason, wchar_t is incorrectly detected with uclibc
 > resulting in the following build failure:

 > In file included from igetevent.c:136:
 > imb_api.h:150:5: error: unknown type name 'wchar_t'
 >   150 |     wchar_t *Buffer;
 >       |     ^~~~~~~

 > The build failure can be reproduced even when reverting bump to version
 > 3.1.8.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/e9ff3bd08e106dc834968bf5e4296ce8299027f8

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot