Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali
@ 2023-02-20 11:24 Fabrice Fontaine
  2023-02-20 14:07 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2023-02-20 11:24 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Fabrice Fontaine

Fix the following build failure with rockchip-mali raised since commit
97c74a73e5dee17530647f89b2c7d8692781eb14:

checking for glesv2... no
configure: error: Package requirements (glesv2 >= 1) were not met:

Package dependency requirement 'glesv2 >= 1' could not be satisfied.
Package 'glesv2' has version '', required version is '>= 1'

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables glesv2_CFLAGS
and glesv2_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

Fixes:
 - http://autobuild.buildroot.org/results/ac765b0ff5f914df4087ae4691fe711dc912f03b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...gure.ac-fix-build-with-rockchip-mali.patch | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 package/glslsandbox-player/0001-configure.ac-fix-build-with-rockchip-mali.patch

diff --git a/package/glslsandbox-player/0001-configure.ac-fix-build-with-rockchip-mali.patch b/package/glslsandbox-player/0001-configure.ac-fix-build-with-rockchip-mali.patch
new file mode 100644
index 0000000000..97bfe00401
--- /dev/null
+++ b/package/glslsandbox-player/0001-configure.ac-fix-build-with-rockchip-mali.patch
@@ -0,0 +1,46 @@
+From b811d408fe52fd5ee5a908eb16a2ff2b4217c235 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Mon, 20 Feb 2023 11:53:39 +0100
+Subject: [PATCH 1/1] configure.ac: fix build with rockchip-mali
+
+Don't check glesv2 version in glesv2.pc file to avoid the following
+build failure with rockchip-mali:
+
+checking for glesv2... no
+configure: error: Package requirements (glesv2 >= 1) were not met:
+
+Package dependency requirement 'glesv2 >= 1' could not be satisfied.
+Package 'glesv2' has version '', required version is '>= 1'
+
+Consider adjusting the PKG_CONFIG_PATH environment variable if you
+installed software in a non-standard prefix.
+
+Alternatively, you may set the environment variables glesv2_CFLAGS
+and glesv2_LIBS to avoid the need to call pkg-config.
+See the pkg-config man page for more details.
+
+Fixes:
+ - http://autobuild.buildroot.org/results/ac765b0ff5f914df4087ae4691fe711dc912f03b
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/jolivain/glslsandbox-player/pull/5]
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 1f45b1f..5cb2d4c 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -84,7 +84,7 @@ AS_IF([test "x$enable_strict_gles" = "xyes"], [
+ ])
+ 
+ PKG_CHECK_MODULES([egl], [egl >= 1])
+-PKG_CHECK_MODULES([glesv2], [glesv2 >= 1])
++PKG_CHECK_MODULES([glesv2], [glesv2])
+ 
+ AC_CHECK_HEADERS([EGL/eglext.h], [], [],
+ [[#include <EGL/egl.h>
+-- 
+2.39.0
+
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali
  2023-02-20 11:24 [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali Fabrice Fontaine
@ 2023-02-20 14:07 ` Thomas Petazzoni via buildroot
  2023-02-20 14:23   ` Fabrice Fontaine
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-20 14:07 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Julien Olivain, buildroot

On Mon, 20 Feb 2023 12:24:10 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> + PKG_CHECK_MODULES([egl], [egl >= 1])
> +-PKG_CHECK_MODULES([glesv2], [glesv2 >= 1])
> ++PKG_CHECK_MODULES([glesv2], [glesv2])

Is this the proper solution, or is the proper solution to patch
rockchip-mali's .pc file?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali
  2023-02-20 14:07 ` Thomas Petazzoni via buildroot
@ 2023-02-20 14:23   ` Fabrice Fontaine
  2023-02-20 14:59     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2023-02-20 14:23 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Julien Olivain, buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1024 bytes --]

Le lun. 20 févr. 2023 à 15:07, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> a écrit :

> On Mon, 20 Feb 2023 12:24:10 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > + PKG_CHECK_MODULES([egl], [egl >= 1])
> > +-PKG_CHECK_MODULES([glesv2], [glesv2 >= 1])
> > ++PKG_CHECK_MODULES([glesv2], [glesv2])
>
> Is this the proper solution, or is the proper solution to patch
> rockchip-mali's .pc file?
>

Patching rockchip-mali is probably better but I don't know what version
number should be put inside glesv2.pc.
Should I hardcode 2 in the pkgconfig file?
Moreover, should I patch the file through a sed in buildroot or send an
upstream patch?
Upstreaming this change is probably impossible as rockchip-mali uses a
commit from October 2018 and the pkgconfig is not available anymore in
usptream master.


>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 1731 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali
  2023-02-20 14:23   ` Fabrice Fontaine
@ 2023-02-20 14:59     ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-20 14:59 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Julien Olivain, buildroot

On Mon, 20 Feb 2023 15:23:42 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Patching rockchip-mali is probably better but I don't know what version
> number should be put inside glesv2.pc.
> Should I hardcode 2 in the pkgconfig file?

I guess whatever works for glslsandbox-player. Packages like
rockchip-mali are anyway crappy.

> Moreover, should I patch the file through a sed in buildroot or send an
> upstream patch?
> Upstreaming this change is probably impossible as rockchip-mali uses a
> commit from October 2018 and the pkgconfig is not available anymore in
> usptream master.

I suppose a patch is fine, and it won't be upstream. As said above,
those OpenGL blobs are anyway crappy :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-20 14:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 11:24 [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali Fabrice Fontaine
2023-02-20 14:07 ` Thomas Petazzoni via buildroot
2023-02-20 14:23   ` Fabrice Fontaine
2023-02-20 14:59     ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox