From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tmux: fix BR2_SHARED_STATIC_LIBS
Date: Mon, 20 Feb 2023 22:10:17 +0100 [thread overview]
Message-ID: <20230220211017.GF2718518@scaer> (raw)
In-Reply-To: <20230219232301.1795196-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2023-02-20 00:23 +0100, Fabrice Fontaine spake thusly:
> tmux uses custom --enable-static option, instead of standard libtool
> directive
In fact, the purpose is also different: libtool's --enable-static drives
whether to generate static libraries, while tmux' --enable-static drives
whether to link against static libraries.
So, not unrelated, but still different.
> resulting in the following build failure with systemd or
> utf8proc raised since commits
> 1f618aa388535181c281c85e2b5264532de4ef0f and
> e279599d255a79c08ef20b97b96eb248689d52a9:
>
> checking for utf8proc.h... yes
> checking for library containing utf8proc_charwidth... no
> configure: error: "utf8proc not found"
>
> In file included from tmux.h:34,
> from alerts.c:23:
> compat.h:379:18: error: conflicting types for 'forkpty'; have 'pid_t(int *, char *, struct termios *, struct winsize *)' {aka 'int(int *, char *, struct termios *, struct winsize *)'}
> 379 | pid_t forkpty(int *, char *, struct termios *, struct winsize *);
> | ^~~~~~~
>
> Link to (closed) upstream issue:
> https://github.com/tmux/tmux/issues/3290
>
> Fixes:
> - http://autobuild.buildroot.org/results/6e8523d8d514bf6d8fc3377d05e5edbe7fc2d5bb
> - http://autobuild.buildroot.org/results/cba06f3bb6d9be25e91f56c390a70ddf9904832e
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/tmux/tmux.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/tmux/tmux.mk b/package/tmux/tmux.mk
> index 47ee9b16ca..af06c8570b 100644
> --- a/package/tmux/tmux.mk
> +++ b/package/tmux/tmux.mk
> @@ -25,6 +25,12 @@ else
> TMUX_CONF_OPTS += --disable-utf8proc
> endif
>
> +# tmux uses custom --enable-static option, instead of standard libtool
> +# directive resulting in a build failure with systemd or utf8proc
> +ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> +TMUX_CONF_OPTS += --disable-static
> +endif
> +
> # Add /usr/bin/tmux to /etc/shells otherwise some login tools like dropbear
> # can reject the user connection. See man shells.
> define TMUX_ADD_TMUX_TO_SHELLS
> --
> 2.39.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-21 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 23:23 [Buildroot] [PATCH 1/1] package/tmux: fix BR2_SHARED_STATIC_LIBS Fabrice Fontaine
2023-02-20 21:07 ` Thomas Petazzoni via buildroot
2023-02-20 22:23 ` Fabrice Fontaine
2023-02-20 21:10 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220211017.GF2718518@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox