Re: [Buildroot] [PATCH 1/1] package/tmux: fix BR2_SHARED_STATIC_LIBS

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tmux: fix BR2_SHARED_STATIC_LIBS
Date: Mon, 20 Feb 2023 22:07:41 +0100	[thread overview]
Message-ID: <20230220220741.1f38012c@windsurf> (raw)
In-Reply-To: <20230219232301.1795196-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Mon, 20 Feb 2023 00:23:01 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> tmux uses custom --enable-static option, instead of standard libtool
> directive resulting in the following build failure with systemd or
> utf8proc raised since commits
> 1f618aa388535181c281c85e2b5264532de4ef0f and
> e279599d255a79c08ef20b97b96eb248689d52a9:

I am rather confused by the reasoning here.

> checking for utf8proc.h... yes
> checking for library containing utf8proc_charwidth... no
> configure: error: "utf8proc not found"

So this one is:

  http://autobuild.buildroot.net/results/6e8/6e8523d8d514bf6d8fc3377d05e5edbe7fc2d5bb/build-end.log
  http://autobuild.buildroot.net/results/623/62309091c9da69eb29c3e9464aa95d089ce886f8/build-end.log

I think here the problem is indeed that tmux interprets --enable-static
as "please provide a statically linked binary" instead of the standard
"please build/install static libraries".

So, when it tries to detect libutf8proc, it doesn't find it:

/home/autobuild/autobuild/instance-13/output-1/host/lib/gcc/or1k-buildroot-linux-musl/11.3.0/../../../../or1k-buildroot-linux-musl/bin/ld: cannot find -lutf8proc: No such file or directory

because utf8proc is based on CMake, and CMake is not able to build both
shared and static libraries, so in the BR2_STATIC_SHARED_LIBS=y case,
it only installs shared libraries. Because the above utf8proc library
test is done with -static, it requires a static variant of libutf8proc,
which isn't there.

So indeed, for this case, it makes sense to not pass --enable-static to
tmux, but it's both due to tmux having a non-standard behavior for
--enable-static *AND* the fact that utf8proc also doesn't behave
properly in the BR2_STATIC_SHARED_LIBS=y case.

> In file included from tmux.h:34,
>                  from alerts.c:23:
> compat.h:379:18: error: conflicting types for 'forkpty'; have 'pid_t(int *, char *, struct termios *, struct winsize *)' {aka 'int(int *, char *, struct termios *, struct winsize *)'}
>   379 | pid_t            forkpty(int *, char *, struct termios *, struct winsize *);
>       |                  ^~~~~~~

However this one, I am really, really confused as to how it can be
related to BR2_STATIC_SHARED_LIBS and --enable-static. Could you
provide some more details on the reasoning?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot