Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Aleksander Morgado <aleksander@aleksander.es>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/modem-manager: needs dynamic library
Date: Mon, 20 Feb 2023 21:46:52 +0100	[thread overview]
Message-ID: <20230220214652.029e413b@windsurf> (raw)
In-Reply-To: <20230220092516.17774-1-fontaine.fabrice@gmail.com>

On Mon, 20 Feb 2023 10:25:16 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit d769cfc13f6c2544f8bc5b6339d23763319a2383 was incomplete as
> plugins/meson.build still unconditionally calls shared_module. So add a
> dependency to dynamic library to avoid the following static build
> failure raised since bump to version 1.20.2 in commit
> b95334b71fbdde0f7621b58ed35fa98df9e0966d:
> 
> [238/417] Linking target plugins/libmm-shared-telit.so
> FAILED: plugins/libmm-shared-telit.so
> 
> Building statically could be enabled back through builtin_plugins as
> soon as
> https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/1c4da332ee6e0d948f85a63f74cb27e89075c011
> lands in a stable release
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/deb2a752accb021392bb9dc3d06b2b1bf151535c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Aleksander Morgado):
>  - Disable building statically instead of disabling all plugins

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-02-20 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  9:25 [Buildroot] [PATCH v2, 1/1] package/modem-manager: needs dynamic library Fabrice Fontaine
2023-02-20 20:46 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230220214652.029e413b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=aleksander@aleksander.es \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox