[Buildroot] [PATCH v2, 1/1] package/modem-manager: needs dynamic library

[Buildroot] [PATCH v2, 1/1] package/modem-manager: needs dynamic library

[Fabrice Fontaine]

Commit d769cfc13f6c2544f8bc5b6339d23763319a2383 was incomplete as
plugins/meson.build still unconditionally calls shared_module. So add a
dependency to dynamic library to avoid the following static build
failure raised since bump to version 1.20.2 in commit
b95334b71fbdde0f7621b58ed35fa98df9e0966d:

[238/417] Linking target plugins/libmm-shared-telit.so
FAILED: plugins/libmm-shared-telit.so

Building statically could be enabled back through builtin_plugins as
soon as
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/1c4da332ee6e0d948f85a63f74cb27e89075c011
lands in a stable release

Fixes:
 - http://autobuild.buildroot.org/results/deb2a752accb021392bb9dc3d06b2b1bf151535c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Aleksander Morgado):
 - Disable building statically instead of disabling all plugins

 package/modem-manager/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index 8489e6fc86..6990996a86 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_MODEM_MANAGER
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
@@ -39,6 +40,7 @@ comment "QRTR support needs a toolchain w/ headers >= 4.15"
 
 endif
 
-comment "modemmanager needs a toolchain w/ wchar, threads"
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+comment "modemmanager needs a toolchain w/ wchar, threads, dynamic library"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
 	depends on BR2_USE_MMU
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/modem-manager: needs dynamic library

[Thomas Petazzoni via buildroot]

On Mon, 20 Feb 2023 10:25:16 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit d769cfc13f6c2544f8bc5b6339d23763319a2383 was incomplete as
> plugins/meson.build still unconditionally calls shared_module. So add a
> dependency to dynamic library to avoid the following static build
> failure raised since bump to version 1.20.2 in commit
> b95334b71fbdde0f7621b58ed35fa98df9e0966d:
> 
> [238/417] Linking target plugins/libmm-shared-telit.so
> FAILED: plugins/libmm-shared-telit.so
> 
> Building statically could be enabled back through builtin_plugins as
> soon as
> https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/1c4da332ee6e0d948f85a63f74cb27e89075c011
> lands in a stable release
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/deb2a752accb021392bb9dc3d06b2b1bf151535c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Aleksander Morgado):
>  - Disable building statically instead of disabling all plugins

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot