Re: [Buildroot] [PATCH 1/1] package/systemd: disable with -Ofast

["Yann E. MORIN" <yann.morin.1998@free.fr>]

On 2023-02-21 21:26 +0100, Thomas Petazzoni spake thusly:
> On Tue, 21 Feb 2023 21:08:57 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> > Alternatively, as the upstream commit also implies, maybe we should in
> > this case keep -Ofast and just add:
> > 
> >     SYSTEMD_CFLAGS = $(TARGET_CFLAGS) -fno-finite-math-only
> 
> But the upstream commit causes the build to bail out as soon as -Ofast
> is in the CFLAGS, so even if you specify -Ofast -fno-finite-math-only,
> systemd's meson machinery will bail out.

The upstream code is (split for readability):

     if (('-Ofast' in c_args or
          '-ffast-math' in c_args or
          '-ffinite-math-only' in c_args
         ) and
         not '-fno-finite-math-only' in c_args
        )

So, if -fno-finite-math-only is in c_args, then the whole condition
should evaluate to false, and thus it should not error out, right?

Or did I lose more than my grep-fu? ;-)

Regards,
Yann E. MORIN.

> So your other idea of:
> 
> SYSTEMD_CFLAGS = $(filter-out -Ofast,$(TARGET_CFLAGS))
> 
> certainly looks very relevant.
> 
> Fabrice, could you give it a try?
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot