Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Norbert Lange <nolange79@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Sen Hastings <sen@phobosdpl.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/systemd: disable with -Ofast
Date: Tue, 21 Feb 2023 21:26:34 +0100	[thread overview]
Message-ID: <20230221212634.736f8d70@windsurf> (raw)
In-Reply-To: <20230221200857.GG2718518@scaer>

On Tue, 21 Feb 2023 21:08:57 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Alternatively, as the upstream commit also implies, maybe we should in
> this case keep -Ofast and just add:
> 
>     SYSTEMD_CFLAGS = $(TARGET_CFLAGS) -fno-finite-math-only

But the upstream commit causes the build to bail out as soon as -Ofast
is in the CFLAGS, so even if you specify -Ofast -fno-finite-math-only,
systemd's meson machinery will bail out.

So your other idea of:

SYSTEMD_CFLAGS = $(filter-out -Ofast,$(TARGET_CFLAGS))

certainly looks very relevant.

Fabrice, could you give it a try?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-21 20:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 14:21 [Buildroot] [PATCH 1/1] package/systemd: disable with -Ofast Fabrice Fontaine
2023-02-21 14:48 ` Thomas Petazzoni via buildroot
2023-02-21 20:08   ` Yann E. MORIN
2023-02-21 20:26     ` Thomas Petazzoni via buildroot [this message]
2023-02-21 20:34       ` Yann E. MORIN
2023-02-21 20:49         ` Thomas Petazzoni via buildroot
2023-02-21 21:15           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221212634.736f8d70@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=nolange79@gmail.com \
    --cc=sen@phobosdpl.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox