[Buildroot] [RE]Re: [PATCH] boot/grub2: add information where isconfiguration file

[Buildroot] [RE]Re: [PATCH] boot/grub2: add information where isconfiguration file

[Andrei Cherniaev]

[-- Attachment #1.1: Type: text/plain, Size: 1980 bytes --]

Hello Thomas Petazzoni"boot/grub2/grub.cfg: it is part of Buildroot itself, and you probably don't want to have project-specific changes in there."You say that I try to set project-specific settings. Look at Buildroot, it set project-specific set default="0"set timeout="5"Why? Why 5, not 6? Buildroot shouldn't set project-specific settings, isn't it? May be maintainer should just removeset default="0"set timeout="5"from grub.cfg ?Andrei Cherniaev----- Original Message -----From : Thomas Petazzoni <thomas.petazzoni@bootlin.com>To : "AndreiCherniaev" <cherniaev.andrei@kairo.space>Cc : <buildroot@buildroot.org>Sent : 2023-02-22 07:02:02Subject : Re: [Buildroot] [PATCH] boot/grub2: add information where isconfiguration fileHello Andrei,On Mon,  9 Jan 2023 16:33:52 +0900AndreiCherniaev <cherniaev.andrei@kairo.space> wrote:> diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in> index 92b5dd501b..bf0400c08f 100644> --- a/boot/grub2/Config.in> +++ b/boot/grub2/Config.in> @@ -125,6 +125,7 @@ config BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC>  	  into the Grub image itself. This allows to set the root>  	  device and other configuration parameters, but however menu>  	  entries cannot be described in this embedded configuration.> +	  Use boot/grub2/grub.cfg to edit menu entries.Actually no, you probably don't want to change boot/grub2/grub.cfg: itis part of Buildroot itself, and you probably don't want to haveproject-specific changes in there.Instead, you should override it using a rootfs overlay (if grub.cfg isin $(TARGET_DIR)/boot) or a post-build/post-image script (if it's inthe EFI partition).I have nevertheless applied your patch, but after tweaking the messagein the help text, and moving it to the main Grub2 option. See:  https://gitlab.com/buildroot.org/buildroot/-/commit/7692d5beb2d9e4d0b463f0f26a177829e5bcc1ecBest regards,Thomas Petazzoni-- Thomas Petazzoni, co-owner and CEO, BootlinEmbedded Linux and Kernel engineering and traininghttps://bootlin.com

[-- Attachment #1.2: Type: text/html, Size: 2675 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [RE]Re: [PATCH] boot/grub2: add information where isconfiguration file

[Thomas Petazzoni via buildroot]

Hello Andrei,

Sorry but the plain text version of your e-mail is unreadable. Could
you use an e-mail client that sends a proper plain text version of its
e-mails?

Thanks a lot,

Thomas Petazzoni

On Wed, 22 Feb 2023 18:30:55 +0900
Andrei Cherniaev <cherniaev.andrei@kairo.space> wrote:

> Hello Thomas Petazzoni"boot/grub2/grub.cfg: it is part of Buildroot itself, and you probably don't want to have project-specific changes in there."You say that I try to set project-specific settings. Look at Buildroot, it set project-specific set default="0"set timeout="5"Why? Why 5, not 6? Buildroot shouldn't set project-specific settings, isn't it? May be maintainer should just removeset default="0"set timeout="5"from grub.cfg ?Andrei Cherniaev----- Original Message -----From : Thomas Petazzoni <thomas.petazzoni@bootlin.com>To : "AndreiCherniaev" <cherniaev.andrei@kairo.space>Cc : <buildroot@buildroot.org>Sent : 2023-02-22 07:02:02Subject : Re: [Buildroot] [PATCH] boot/grub2: add information where isconfiguration fileHello Andrei,On Mon,  9 Jan 2023 16:33:52 +0900AndreiCherniaev <cherniaev.andrei@kairo.space> wrote:> diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in> index 92b5dd501b..bf0400c08f 100644> --- a/boot/grub2/Config.in> +++ b/boot/grub2/Config.in> @@ -125,6 +125
 ,7 @@ config BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC>  	  into the Grub image itself. This allows to set the root>  	  device and other configuration parameters, but however menu>  	  entries cannot be described in this embedded configuration.> +	  Use boot/grub2/grub.cfg to edit menu entries.Actually no, you probably don't want to change boot/grub2/grub.cfg: itis part of Buildroot itself, and you probably don't want to haveproject-specific changes in there.Instead, you should override it using a rootfs overlay (if grub.cfg isin $(TARGET_DIR)/boot) or a post-build/post-image script (if it's inthe EFI partition).I have nevertheless applied your patch, but after tweaking the messagein the help text, and moving it to the main Grub2 option. See:  https://gitlab.com/buildroot.org/buildroot/-/commit/7692d5beb2d9e4d0b463f0f26a177829e5bcc1ecBest regards,Thomas Petazzoni-- Thomas Petazzoni, co-owner and CEO, BootlinEmbedded Linux and Kernel engineering and traininghttps://bootlin.com


-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot