* [Buildroot] [PATCH] package/wilc-driver: fix build failure due to wrong pointer casts
@ 2022-12-31 17:42 Giulio Benetti
2023-02-22 15:05 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2022-12-31 17:42 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Kris Bahnsen
Add local patch pending upstream[0] to fix the bug.
[0]: https://github.com/embeddedTS/wilc3000-external-module/pull/3
Fixes:
http://autobuild.buildroot.net/results/0a0/0a022d5c053bf8f7a53349b8bae4b2168a9cd134/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
.../wilc-driver/0005-Fix-cast-warnings.patch | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 package/wilc-driver/0005-Fix-cast-warnings.patch
diff --git a/package/wilc-driver/0005-Fix-cast-warnings.patch b/package/wilc-driver/0005-Fix-cast-warnings.patch
new file mode 100644
index 0000000000..713a15e667
--- /dev/null
+++ b/package/wilc-driver/0005-Fix-cast-warnings.patch
@@ -0,0 +1,43 @@
+From ebd083223883d479b2dd6f8a0da272797f90d236 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Sat, 31 Dec 2022 18:38:33 +0100
+Subject: [PATCH] Fix cast warnings
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ cfg80211.c | 2 +-
+ netdev.c | 4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/cfg80211.c b/cfg80211.c
+index 016aa06..2f40c9d 100644
+--- a/cfg80211.c
++++ b/cfg80211.c
+@@ -1794,7 +1794,7 @@ static int start_ap(struct wiphy *wiphy, struct net_device *dev,
+ if (ret != 0)
+ netdev_err(dev, "Error in setting channel\n");
+
+- wilc_wlan_set_bssid(dev, dev->dev_addr, WILC_AP_MODE);
++ wilc_wlan_set_bssid(dev, (u8 *)dev->dev_addr, WILC_AP_MODE);
+
+ return wilc_add_beacon(vif, settings->beacon_interval,
+ settings->dtim_period, &settings->beacon);
+diff --git a/netdev.c b/netdev.c
+index 824afea..5a1a51d 100644
+--- a/netdev.c
++++ b/netdev.c
+@@ -899,9 +899,9 @@ static int wilc_mac_open(struct net_device *ndev)
+ vif->idx);
+
+ if (is_valid_ether_addr(ndev->dev_addr))
+- wilc_set_mac_address(vif, ndev->dev_addr);
++ wilc_set_mac_address(vif, (u8 *)ndev->dev_addr);
+ else
+- wilc_get_mac_address(vif, ndev->dev_addr);
++ wilc_get_mac_address(vif, (u8 *)ndev->dev_addr);
+ netdev_dbg(ndev, "Mac address: %pM\n", ndev->dev_addr);
+
+ if (!is_valid_ether_addr(ndev->dev_addr)) {
+--
+2.34.1
+
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to wrong pointer casts
2022-12-31 17:42 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to wrong pointer casts Giulio Benetti
@ 2023-02-22 15:05 ` Thomas Petazzoni via buildroot
2023-03-05 17:28 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-22 15:05 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Kris Bahnsen, buildroot
On Sat, 31 Dec 2022 18:42:08 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Add local patch pending upstream[0] to fix the bug.
>
> [0]: https://github.com/embeddedTS/wilc3000-external-module/pull/3
>
> Fixes:
> http://autobuild.buildroot.net/results/0a0/0a022d5c053bf8f7a53349b8bae4b2168a9cd134/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> .../wilc-driver/0005-Fix-cast-warnings.patch | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 package/wilc-driver/0005-Fix-cast-warnings.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to wrong pointer casts
2023-02-22 15:05 ` Thomas Petazzoni via buildroot
@ 2023-03-05 17:28 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-03-05 17:28 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: Giulio Benetti, Kris Bahnsen, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Sat, 31 Dec 2022 18:42:08 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>> Add local patch pending upstream[0] to fix the bug.
>>
>> [0]: https://github.com/embeddedTS/wilc3000-external-module/pull/3
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/0a0/0a022d5c053bf8f7a53349b8bae4b2168a9cd134/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> .../wilc-driver/0005-Fix-cast-warnings.patch | 43 +++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>> create mode 100644 package/wilc-driver/0005-Fix-cast-warnings.patch
> Applied to master, thanks.
Committed to 2022.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-05 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-31 17:42 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to wrong pointer casts Giulio Benetti
2023-02-22 15:05 ` Thomas Petazzoni via buildroot
2023-03-05 17:28 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox