From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Simon Dawson <spdawson@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency
Date: Sat, 25 Feb 2023 10:44:23 +0100 [thread overview]
Message-ID: <20230225104423.3a9cc6ab@windsurf> (raw)
In-Reply-To: <20230224101720.1458102-1-fontaine.fabrice@gmail.com>
On Fri, 24 Feb 2023 11:17:20 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> +ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> +XSCREENSAVER_CONF_OPTS += --with-pam=yes
> +XSCREENSAVER_DEPENDENCIES += linux-pam
> +else
> +XSCREENSAVER_CONF_OPTS += --with-pam=no
> +endif
Any reason not to use --with-pam/--without-pam like we do in Buildroot,
rather than --with-pam=yes/--with-pam=no?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-25 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 10:17 [Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency Fabrice Fontaine
2023-02-25 9:44 ` Thomas Petazzoni via buildroot [this message]
2023-02-25 10:39 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230225104423.3a9cc6ab@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=spdawson@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox