[Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency

[Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency

[Fabrice Fontaine]

Fixes:
 - https://bugs.buildroot.org/show_bug.cgi?id=15316

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/xscreensaver/xscreensaver.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/xscreensaver/xscreensaver.mk b/package/xscreensaver/xscreensaver.mk
index 6cc7e8febe..dc5f8b7e1e 100644
--- a/package/xscreensaver/xscreensaver.mk
+++ b/package/xscreensaver/xscreensaver.mk
@@ -42,6 +42,13 @@ else
 XSCREENSAVER_CONF_OPTS += --with-png=no
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+XSCREENSAVER_CONF_OPTS += --with-pam=yes
+XSCREENSAVER_DEPENDENCIES += linux-pam
+else
+XSCREENSAVER_CONF_OPTS += --with-pam=no
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 XSCREENSAVER_CONF_OPTS += --with-systemd=yes
 XSCREENSAVER_DEPENDENCIES += systemd
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency

[Thomas Petazzoni via buildroot]

On Fri, 24 Feb 2023 11:17:20 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> +ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> +XSCREENSAVER_CONF_OPTS += --with-pam=yes
> +XSCREENSAVER_DEPENDENCIES += linux-pam
> +else
> +XSCREENSAVER_CONF_OPTS += --with-pam=no
> +endif

Any reason not to use --with-pam/--without-pam like we do in Buildroot,
rather than --with-pam=yes/--with-pam=no?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xscreensaver: add linux-pam optional dependency

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 796 bytes --]

Le sam. 25 févr. 2023 à 10:44, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> a écrit :

> On Fri, 24 Feb 2023 11:17:20 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > +ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> > +XSCREENSAVER_CONF_OPTS += --with-pam=yes
> > +XSCREENSAVER_DEPENDENCIES += linux-pam
> > +else
> > +XSCREENSAVER_CONF_OPTS += --with-pam=no
> > +endif
>
> Any reason not to use --with-pam/--without-pam like we do in Buildroot,
> rather than --with-pam=yes/--with-pam=no?
>

The only reason is for consistency with the other options in xscreensaver.mk
.


>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 1555 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot