* [Buildroot] [PATCH 1/1] package/ntpsec: fix build without stack-protector
@ 2023-02-24 10:51 Fabrice Fontaine
2023-02-25 9:49 ` Thomas Petazzoni via buildroot
2023-03-13 17:09 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-02-24 10:51 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Fix the following build failure without stack-protector raised since the
addition of the package in commit
27b8d0ba8c4004819e092fb81c0f64f284b3aa4a:
Checking for library ssp : not found
Checking for library ssp_nonshared : not found
Checking if C compiler supports -fstack-protector-all : yes
[...]
The configuration failed
(complete log in /home/autobuild/autobuild/instance-2/output-1/build/ntpsec-1_2_2/build/config.log)
Fixes:
- http://autobuild.buildroot.org/results/f38abc6b7f8464836231192cfe078a5b27319a8a
- http://autobuild.buildroot.org/results/62be818e2f2eac07b4a2de6f4a8898cc4cc05b1f
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...pt-fix-build-without-stack-protector.patch | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 package/ntpsec/0002-wscript-fix-build-without-stack-protector.patch
diff --git a/package/ntpsec/0002-wscript-fix-build-without-stack-protector.patch b/package/ntpsec/0002-wscript-fix-build-without-stack-protector.patch
new file mode 100644
index 0000000000..f494bf479c
--- /dev/null
+++ b/package/ntpsec/0002-wscript-fix-build-without-stack-protector.patch
@@ -0,0 +1,50 @@
+From 0a3ce09c14eb9c7e36aa30a4dafe40e56676d678 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 24 Feb 2023 11:33:32 +0100
+Subject: [PATCH] wscript: fix build without stack-protector
+
+-fstack-protector-all can depends on ssp library availability (e.g. on musl) so
+move the test from cc_test_flags to ld_hardening_flags, this will avoid the
+following build failure:
+
+Checking for library ssp : not found
+Checking for library ssp_nonshared : not found
+Checking if C compiler supports -fstack-protector-all : yes
+
+[...]
+
+The configuration failed
+(complete log in /home/autobuild/autobuild/instance-2/output-1/build/ntpsec-1_2_2/build/config.log)
+
+Fixes:
+ - http://autobuild.buildroot.org/results/f38abc6b7f8464836231192cfe078a5b27319a8a
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/ntpsec/ntpsec/pull/6]
+---
+ wscript | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/wscript b/wscript
+index be396b33b..f301809fc 100644
+--- a/wscript
++++ b/wscript
+@@ -298,7 +298,6 @@ def configure(ctx):
+ ctx.env.LDFLAGS += ["-lssp_nonshared"]
+
+ cc_test_flags = [
+- ('f_stack_protector_all', '-fstack-protector-all'),
+ ('PIC', '-fPIC'),
+ ('PIE', '-pie -fPIE'),
+ # this quiets most of macOS warnings on -fpie
+@@ -332,6 +331,7 @@ def configure(ctx):
+
+ # Check which linker flags are supported
+ ld_hardening_flags = [
++ ('f_stack_protector_all', '-fstack-protector-all'),
+ ("z_now", "-Wl,-z,now"), # no deferred symbol resolution
+ ]
+
+--
+2.39.1
+
--
2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-13 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-24 10:51 [Buildroot] [PATCH 1/1] package/ntpsec: fix build without stack-protector Fabrice Fontaine
2023-02-25 9:49 ` Thomas Petazzoni via buildroot
2023-03-13 17:09 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox