* [Buildroot] [PATCH 1/1] configs/orangepi_pc2: add board support
@ 2023-03-01 8:35 Javad Rahimi
2023-03-02 3:25 ` [Buildroot] Help for the first patch: " Javad Rahimipetroudi
2023-03-14 8:31 ` [Buildroot] " Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Javad Rahimi @ 2023-03-01 8:35 UTC (permalink / raw)
To: buildroot; +Cc: javad321javad
add board support for orangepi pc2
Signed-off-by: Javad Rahimi <javad321javad@gmail.com>
---
configs/orangepi_pc2_defconfig | 41 ++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 configs/orangepi_pc2_defconfig
diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
new file mode 100644
index 0000000000..63ee554caf
--- /dev/null
+++ b/configs/orangepi_pc2_defconfig
@@ -0,0 +1,41 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_TARGET_GENERIC_ISSUE="Welcome to Orangepi PC2"
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16.1"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-h5-orangepi-pc2"
+BR2_LINUX_KERNEL_DTB_KEEP_DIRNAME=y
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_PACKAGE_LINUX_FIRMWARE=y
+BR2_PACKAGE_LIBNL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.5"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.01"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="orangepi_pc2"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
+BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
+BR2_PACKAGE_HOST_GENIMAGE=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] Help for the first patch: [PATCH 1/1] configs/orangepi_pc2: add board support
2023-03-01 8:35 [Buildroot] [PATCH 1/1] configs/orangepi_pc2: add board support Javad Rahimi
@ 2023-03-02 3:25 ` Javad Rahimipetroudi
2023-03-14 8:31 ` [Buildroot] " Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Javad Rahimipetroudi @ 2023-03-02 3:25 UTC (permalink / raw)
To: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 2514 bytes --]
Hello,
It is my first time that I sent a patch. I followed the guidelines to add
support for a missed board (OrangePi PC2)
Is anything else required? I would be grateful if you help me.
Best Regards,
Javad
---------- Forwarded message ---------
From: Javad Rahimi <javad321javad@gmail.com>
Date: Wed, Mar 1, 2023, 12:06
Subject: [PATCH 1/1] configs/orangepi_pc2: add board support
To: <buildroot@buildroot.org>
Cc: <javad321javad@gmail.com>
add board support for orangepi pc2
Signed-off-by: Javad Rahimi <javad321javad@gmail.com>
---
configs/orangepi_pc2_defconfig | 41 ++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 configs/orangepi_pc2_defconfig
diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
new file mode 100644
index 0000000000..63ee554caf
--- /dev/null
+++ b/configs/orangepi_pc2_defconfig
@@ -0,0 +1,41 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_TARGET_GENERIC_ISSUE="Welcome to Orangepi PC2"
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16.1"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-h5-orangepi-pc2"
+BR2_LINUX_KERNEL_DTB_KEEP_DIRNAME=y
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_PACKAGE_LINUX_FIRMWARE=y
+BR2_PACKAGE_LIBNL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.5"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.01"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="orangepi_pc2"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
+BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
+BR2_PACKAGE_HOST_GENIMAGE=y
--
2.34.1
[-- Attachment #1.2: Type: text/html, Size: 3520 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] configs/orangepi_pc2: add board support
2023-03-01 8:35 [Buildroot] [PATCH 1/1] configs/orangepi_pc2: add board support Javad Rahimi
2023-03-02 3:25 ` [Buildroot] Help for the first patch: " Javad Rahimipetroudi
@ 2023-03-14 8:31 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-03-14 8:31 UTC (permalink / raw)
To: Javad Rahimi; +Cc: buildroot
Hello Javad,
On Wed, 1 Mar 2023 12:05:56 +0330
Javad Rahimi <javad321javad@gmail.com> wrote:
> add board support for orangepi pc2
>
> Signed-off-by: Javad Rahimi <javad321javad@gmail.com>
Thanks for your contribution. For your reference, we used to have a
defconfig for this platform until 2022, at which point it was removed
due to it not being maintained. See the commit that removed it:
https://gitlab.com/buildroot.org/buildroot/-/commit/eeede611f81d8f83b72e4a6671cd7d1e46b266b0
I suggest that you look at this commit to see what could possibly be
missing in your submission.
More comments below.
> ---
> configs/orangepi_pc2_defconfig | 41 ++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
We need an entry in the DEVELOPERS file corresponding to this defconfig
and any other file added by this commit.
We need a readme.txt file somewhere in board/ to document how to use
the defconfig and board. You can read other readme.txt files in board/
to get a feeling of the expected format/content.
> diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
> new file mode 100644
> index 0000000000..63ee554caf
> --- /dev/null
> +++ b/configs/orangepi_pc2_defconfig
> @@ -0,0 +1,41 @@
> +BR2_aarch64=y
> +BR2_ARM_FPU_VFPV4=y
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
This is not needed in a minimal defconfig.
> +BR2_TARGET_GENERIC_ISSUE="Welcome to Orangepi PC2"
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
Any specific reason why mdev is needed?
> +BR2_SYSTEM_DHCP="eth0"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/orangepi/common/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c $(BINARIES_DIR)/genimage.cfg"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16.1"
> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-h5-orangepi-pc2"
> +BR2_LINUX_KERNEL_DTB_KEEP_DIRNAME=y
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_PACKAGE_LINUX_FIRMWARE=y
Why is linux-firmware installed, but without any sub-option enabled?
> +BR2_PACKAGE_LIBNL=y
Why is this needed?
Otherwise, looks good to me. Could you look at the above issues, and
submit a new iteration?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 8:35 [Buildroot] [PATCH 1/1] configs/orangepi_pc2: add board support Javad Rahimi
2023-03-02 3:25 ` [Buildroot] Help for the first patch: " Javad Rahimipetroudi
2023-03-14 8:31 ` [Buildroot] " Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox