Re: [Buildroot] [PATCH 1/1] package/lvm2: enable package with musl

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Simon,

On Thu, 16 Mar 2023 11:36:15 +0000
Simon Rowe <simon.rowe@nutanix.com> wrote:

> LVM uses some glibc-specific functions to try and control locking
> memory in RAM. As a result the package is currently disabled when
> using musl.
> 
> Apply patches taken from gentoo:
> 
>     https://github.com/gentoo/gentoo/pull/25883
>     https://github.com/gentoo/gentoo/pull/26024
> 
> and drop the prohibition on musl in Config.in.
> 
> Signed-off-by: Simon Rowe <simon.rowe@nutanix.com>

Thanks Simon for those patches! Could you rework the 4 patches so that
they are generated with git format-patch and have your Signed-off-by? I
recommend that you take the upstream Git repo of lvm2, checkout the tag
corresponding to version 2.03.14, apply the 4 Gentoo patches, each time
turning the changes into a proper commit.

Another thing to look at is that the multipath-tools package is
selecting BR2_PACKAGE_LVM2_STANDARD_INSTALL, so you need to check
whether the depends on !BR2_TOOLCHAIN_USES_MUSL used in
BR2_PACKAGE_MULTIPATH_TOOLS is still needed? Perhaps thanks to your
work on lvm2 it is now possible to build/use multipath-tools with musl.

Another question is the upstream status of the Gentoo patches? Have
they been submitted for inclusion by the upstream lvm2 project?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot