Re: [Buildroot] [PATCH 1/1] package/lvm2: enable package with musl

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Simon,

On Tue, 21 Mar 2023 13:39:12 +0000
Simon Rowe <simon.rowe@nutanix.com> wrote:

> I am not the author of these patches, which is why I didn’t add a
> ‘Signed-off-by:’. I followed what I thought the process was for
> patches originating from elsewhere by adding a ‘Fetch from:’ to each
> patch as mentioned in 19.4 of the manual. I can regenerate them if
> that’s the correct approach.

A Signed-off-by is not only an indication of the author, but also an
indication of the chain of people through which the patch traveled. For
example in the Linux kernel, patches have a SoB from the author, then a
SoB from the maintainer taking the patch, and possibly another SoB from
yet another maintainer taking the patch from that previous maintainer.

In Buildroot, we therefore have patches with two SoB: one from the
original author, and one from the developer bringing the patch into
Buildroot. Or alternatively patches with only one SoB, from the
developer bringing the patch into Buildroot (you in this case) when the
original patch lacks an SoB.

> I’ve not got a use case for multipath myself by I’ll check if I can
> get it to build with these patches.

Good!

> > Another question is the upstream status of the Gentoo patches? Have
> > they been submitted for inclusion by the upstream lvm2 project?  
> 
> There seems to be a suggestion that was attempted on the ticket
> 
> https://bugs.gentoo.org/549506
> 
> but that was some time ago and there’s no sign of them being accepted.

It's been a while ago. Perhaps time to do another attempt at
upstreaming those patches?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot