From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: Chris Packham <judge.packham@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
Date: Sun, 7 May 2023 14:40:56 +0200 [thread overview]
Message-ID: <20230507124056.GO252090@scaer> (raw)
In-Reply-To: <20230429124731.4014394-1-j.neuschaefer@gmx.net>
Jonathan, All,
On 2023-04-29 14:47 +0200, Jonathan Neuschäfer spake thusly:
> LDFLAGS need to be passed to the micropython build system via the
> LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
Is this fixing an actual issue, or did you just happen to notice by
chance?
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
>
> (resending due to email issues)
> ---
> package/micropython/micropython.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
> index 51b45e5e99..5f687c73b9 100644
> --- a/package/micropython/micropython.mk
> +++ b/package/micropython/micropython.mk
> @@ -36,6 +36,7 @@ MICROPYTHON_MAKE_OPTS += \
> MICROPY_PY_USSL=0 \
> CROSS_COMPILE=$(TARGET_CROSS) \
> CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
> + LDFLAGS_EXTRA="$(TARGET_LDFLAGS)" \
> CWARN=
>
> define MICROPYTHON_BUILD_CMDS
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-07 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
2023-05-07 12:40 ` Yann E. MORIN [this message]
2023-05-07 14:17 ` Jonathan Neuschäfer
2023-05-07 14:41 ` Yann E. MORIN
2023-06-05 20:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507124056.GO252090@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=j.neuschaefer@gmx.net \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox