From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: "Chris Packham" <judge.packham@gmail.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
Date: Sun, 7 May 2023 16:17:30 +0200 [thread overview]
Message-ID: <ZFey+o0AMgSGDnba@probook> (raw)
In-Reply-To: <20230507124056.GO252090@scaer>
[-- Attachment #1.1: Type: text/plain, Size: 782 bytes --]
On Sun, May 07, 2023 at 02:40:56PM +0200, Yann E. MORIN wrote:
> Jonathan, All,
>
> On 2023-04-29 14:47 +0200, Jonathan Neuschäfer spake thusly:
> > LDFLAGS need to be passed to the micropython build system via the
> > LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
>
> Is this fixing an actual issue, or did you just happen to notice by
> chance?
It fixes the issue that global linker flags (such as from
BR2_TARGET_LDFLAGS) are not applied to the micropython build.
Extra LDFLAGS are not necessary most of the time, but I was using
BR2_TARGET_LDFLAGS="-z text" to check for textrels, because micropython
produces one[1] and it causes a crash with musl-libc.
Jonathan
[1]: https://github.com/micropython/micropython/pull/11353
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-07 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
2023-05-07 12:40 ` Yann E. MORIN
2023-05-07 14:17 ` Jonathan Neuschäfer [this message]
2023-05-07 14:41 ` Yann E. MORIN
2023-06-05 20:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFey+o0AMgSGDnba@probook \
--to=j.neuschaefer@gmx.net \
--cc=buildroot@buildroot.org \
--cc=judge.packham@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox