* [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
@ 2023-04-29 12:47 Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jonathan Neuschäfer @ 2023-04-29 12:47 UTC (permalink / raw)
To: buildroot; +Cc: Chris Packham, Jonathan Neuschäfer
LDFLAGS need to be passed to the micropython build system via the
LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
(resending due to email issues)
---
package/micropython/micropython.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
index 51b45e5e99..5f687c73b9 100644
--- a/package/micropython/micropython.mk
+++ b/package/micropython/micropython.mk
@@ -36,6 +36,7 @@ MICROPYTHON_MAKE_OPTS += \
MICROPY_PY_USSL=0 \
CROSS_COMPILE=$(TARGET_CROSS) \
CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
+ LDFLAGS_EXTRA="$(TARGET_LDFLAGS)" \
CWARN=
define MICROPYTHON_BUILD_CMDS
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
@ 2023-04-30 9:01 ` Chris Packham
2023-05-07 12:40 ` Yann E. MORIN
2023-06-05 20:03 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Chris Packham @ 2023-04-30 9:01 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: buildroot
On Sun, Apr 30, 2023 at 12:47 AM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
>
> LDFLAGS need to be passed to the micropython build system via the
> LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Acked-by: Chris Packham <judge.packham@gmail.com>
> ---
>
> (resending due to email issues)
> ---
> package/micropython/micropython.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
> index 51b45e5e99..5f687c73b9 100644
> --- a/package/micropython/micropython.mk
> +++ b/package/micropython/micropython.mk
> @@ -36,6 +36,7 @@ MICROPYTHON_MAKE_OPTS += \
> MICROPY_PY_USSL=0 \
> CROSS_COMPILE=$(TARGET_CROSS) \
> CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
> + LDFLAGS_EXTRA="$(TARGET_LDFLAGS)" \
> CWARN=
>
> define MICROPYTHON_BUILD_CMDS
> --
> 2.39.2
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
@ 2023-05-07 12:40 ` Yann E. MORIN
2023-05-07 14:17 ` Jonathan Neuschäfer
2023-06-05 20:03 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2023-05-07 12:40 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: Chris Packham, buildroot
Jonathan, All,
On 2023-04-29 14:47 +0200, Jonathan Neuschäfer spake thusly:
> LDFLAGS need to be passed to the micropython build system via the
> LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
Is this fixing an actual issue, or did you just happen to notice by
chance?
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
>
> (resending due to email issues)
> ---
> package/micropython/micropython.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
> index 51b45e5e99..5f687c73b9 100644
> --- a/package/micropython/micropython.mk
> +++ b/package/micropython/micropython.mk
> @@ -36,6 +36,7 @@ MICROPYTHON_MAKE_OPTS += \
> MICROPY_PY_USSL=0 \
> CROSS_COMPILE=$(TARGET_CROSS) \
> CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
> + LDFLAGS_EXTRA="$(TARGET_LDFLAGS)" \
> CWARN=
>
> define MICROPYTHON_BUILD_CMDS
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
2023-05-07 12:40 ` Yann E. MORIN
@ 2023-05-07 14:17 ` Jonathan Neuschäfer
2023-05-07 14:41 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Neuschäfer @ 2023-05-07 14:17 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Chris Packham, Jonathan Neuschäfer, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 782 bytes --]
On Sun, May 07, 2023 at 02:40:56PM +0200, Yann E. MORIN wrote:
> Jonathan, All,
>
> On 2023-04-29 14:47 +0200, Jonathan Neuschäfer spake thusly:
> > LDFLAGS need to be passed to the micropython build system via the
> > LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
>
> Is this fixing an actual issue, or did you just happen to notice by
> chance?
It fixes the issue that global linker flags (such as from
BR2_TARGET_LDFLAGS) are not applied to the micropython build.
Extra LDFLAGS are not necessary most of the time, but I was using
BR2_TARGET_LDFLAGS="-z text" to check for textrels, because micropython
produces one[1] and it causes a crash with musl-libc.
Jonathan
[1]: https://github.com/micropython/micropython/pull/11353
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
2023-05-07 14:17 ` Jonathan Neuschäfer
@ 2023-05-07 14:41 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2023-05-07 14:41 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: Chris Packham, buildroot
Jonathan, All,
On 2023-05-07 16:17 +0200, Jonathan Neuschäfer spake thusly:
> On Sun, May 07, 2023 at 02:40:56PM +0200, Yann E. MORIN wrote:
> > Jonathan, All,
> > On 2023-04-29 14:47 +0200, Jonathan Neuschäfer spake thusly:
> > > LDFLAGS need to be passed to the micropython build system via the
> > > LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
> > Is this fixing an actual issue, or did you just happen to notice by
> > chance?
> It fixes the issue that global linker flags (such as from
> BR2_TARGET_LDFLAGS) are not applied to the micropython build.
> Extra LDFLAGS are not necessary most of the time, but I was using
> BR2_TARGET_LDFLAGS="-z text" to check for textrels, because micropython
> produces one[1] and it causes a crash with musl-libc.
I see. Thanks for the feedback!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
2023-05-07 12:40 ` Yann E. MORIN
@ 2023-06-05 20:03 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2023-06-05 20:03 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: Chris Packham, buildroot
>>>>> "Jonathan" == Jonathan Neuschäfer <j.neuschaefer@gmx.net> writes:
> LDFLAGS need to be passed to the micropython build system via the
> LDFLAGS_EXTRA variable, which was so far missing. This patch adds it.
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-05 20:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-29 12:47 [Buildroot] [PATCH] package/micropython: pass $TARGET_LDFLAGS to build Jonathan Neuschäfer
2023-04-30 9:01 ` Chris Packham
2023-05-07 12:40 ` Yann E. MORIN
2023-05-07 14:17 ` Jonathan Neuschäfer
2023-05-07 14:41 ` Yann E. MORIN
2023-06-05 20:03 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox