Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS
@ 2023-05-07 21:34 James Knight
  2023-05-07 21:47 ` Yann E. MORIN
  2023-06-08 20:39 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: James Knight @ 2023-05-07 21:34 UTC (permalink / raw)
  To: buildroot; +Cc: James Knight

Drops the use of `RPM_CFLAGS`, which their use has been obsolete when
this package bumped to v4.17 [1].

[1]: 429e247b869027f6ecd4efa0f31bccd2765e3875

Signed-off-by: James Knight <james.d.knight@live.com>
---
Changes v1 -> v2:
  - This patch has been split across multiple patches; no changes to the
     implementation itself (suggested by Yann E. MORIN)
---
 package/rpm/rpm.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
index fc57a14fd6518ddcd65a90f294ecabbca8057f67..08bcb85ae41701a192330732984401d7092cd492 100644
--- a/package/rpm/rpm.mk
+++ b/package/rpm/rpm.mk
@@ -104,7 +104,6 @@ endif
 # ac_cv_prog_cc_c99: RPM uses non-standard GCC extensions (ex. `asm`).
 RPM_CONF_ENV = \
 	ac_cv_prog_cc_c99='-std=gnu99' \
-	CFLAGS="$(TARGET_CFLAGS) $(RPM_CFLAGS)" \
 	LIBS=$(TARGET_NLS_LIBS)
 
 $(eval $(autotools-package))
-- 
2.40.1.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS
  2023-05-07 21:34 [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS James Knight
@ 2023-05-07 21:47 ` Yann E. MORIN
  2023-06-08 20:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2023-05-07 21:47 UTC (permalink / raw)
  To: James Knight; +Cc: buildroot

James, All,

On 2023-05-07 17:34 -0400, James Knight spake thusly:
> Drops the use of `RPM_CFLAGS`, which their use has been obsolete when
> this package bumped to v4.17 [1].
> 
> [1]: 429e247b869027f6ecd4efa0f31bccd2765e3875
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

Whole series applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - This patch has been split across multiple patches; no changes to the
>      implementation itself (suggested by Yann E. MORIN)
> ---
>  package/rpm/rpm.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> index fc57a14fd6518ddcd65a90f294ecabbca8057f67..08bcb85ae41701a192330732984401d7092cd492 100644
> --- a/package/rpm/rpm.mk
> +++ b/package/rpm/rpm.mk
> @@ -104,7 +104,6 @@ endif
>  # ac_cv_prog_cc_c99: RPM uses non-standard GCC extensions (ex. `asm`).
>  RPM_CONF_ENV = \
>  	ac_cv_prog_cc_c99='-std=gnu99' \
> -	CFLAGS="$(TARGET_CFLAGS) $(RPM_CFLAGS)" \
>  	LIBS=$(TARGET_NLS_LIBS)
>  
>  $(eval $(autotools-package))
> -- 
> 2.40.1.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS
  2023-05-07 21:34 [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS James Knight
  2023-05-07 21:47 ` Yann E. MORIN
@ 2023-06-08 20:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-06-08 20:39 UTC (permalink / raw)
  To: James Knight; +Cc: buildroot

>>>>> "James" == James Knight <james.d.knight@live.com> writes:

 > Drops the use of `RPM_CFLAGS`, which their use has been obsolete when
 > this package bumped to v4.17 [1].

 > [1]: 429e247b869027f6ecd4efa0f31bccd2765e3875

 > Signed-off-by: James Knight <james.d.knight@live.com>
 > ---
 > Changes v1 -> v2:
 >   - This patch has been split across multiple patches; no changes to the
 >      implementation itself (suggested by Yann E. MORIN)

Committed to 2023.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-08 20:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-07 21:34 [Buildroot] [PATCH v2 1/5] package/rpm: drop remnants of custom CFLAGS James Knight
2023-05-07 21:47 ` Yann E. MORIN
2023-06-08 20:39 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox