From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Thomas Devoogdt <thomas@devoogdt.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment
Date: Tue, 16 May 2023 14:50:35 +0300 [thread overview]
Message-ID: <20230516145035.GB2291336@igalia.com> (raw)
In-Reply-To: <20230516080117.18721-1-thomas@devoogdt.com>
[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]
On Tue, 16 May 2023 10:01:17 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Commit 4c7fcbbe75de5c535e8d5dd7182900b6d09e2b03 should have set it to GCC 8.
>
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 976341093e..23c0bf41db 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -21,7 +21,7 @@ comment "webkitgtk needs libgtk3 and a toolchain w/ C++, wchar, threads, dynamic
> depends on !BR2_BINFMT_FLAT
> depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
> !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
> !BR2_HOST_GCC_AT_LEAST_4_9
> depends on BR2_USE_MMU
>
> --
> 2.34.1
>
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-16 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 8:01 [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment Thomas Devoogdt
2023-05-16 11:50 ` Adrian Perez de Castro [this message]
2023-05-16 12:00 ` Peter Korsgaard
2023-06-13 21:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516145035.GB2291336@igalia.com \
--to=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox