* [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment
@ 2023-05-16 8:01 Thomas Devoogdt
2023-05-16 11:50 ` Adrian Perez de Castro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Devoogdt @ 2023-05-16 8:01 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro, Thomas Devoogdt
Commit 4c7fcbbe75de5c535e8d5dd7182900b6d09e2b03 should have set it to GCC 8.
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
package/webkitgtk/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index 976341093e..23c0bf41db 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -21,7 +21,7 @@ comment "webkitgtk needs libgtk3 and a toolchain w/ C++, wchar, threads, dynamic
depends on !BR2_BINFMT_FLAT
depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
- !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
!BR2_HOST_GCC_AT_LEAST_4_9
depends on BR2_USE_MMU
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment
2023-05-16 8:01 [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment Thomas Devoogdt
@ 2023-05-16 11:50 ` Adrian Perez de Castro
2023-05-16 12:00 ` Peter Korsgaard
2023-06-13 21:47 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2023-05-16 11:50 UTC (permalink / raw)
To: Thomas Devoogdt; +Cc: Thomas Devoogdt, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]
On Tue, 16 May 2023 10:01:17 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Commit 4c7fcbbe75de5c535e8d5dd7182900b6d09e2b03 should have set it to GCC 8.
>
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 976341093e..23c0bf41db 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -21,7 +21,7 @@ comment "webkitgtk needs libgtk3 and a toolchain w/ C++, wchar, threads, dynamic
> depends on !BR2_BINFMT_FLAT
> depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
> !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
> !BR2_HOST_GCC_AT_LEAST_4_9
> depends on BR2_USE_MMU
>
> --
> 2.34.1
>
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment
2023-05-16 8:01 [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment Thomas Devoogdt
2023-05-16 11:50 ` Adrian Perez de Castro
@ 2023-05-16 12:00 ` Peter Korsgaard
2023-06-13 21:47 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2023-05-16 12:00 UTC (permalink / raw)
To: Thomas Devoogdt; +Cc: Adrian Perez de Castro, buildroot
>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:
> Commit 4c7fcbbe75de5c535e8d5dd7182900b6d09e2b03 should have set it to GCC 8.
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment
2023-05-16 8:01 [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment Thomas Devoogdt
2023-05-16 11:50 ` Adrian Perez de Castro
2023-05-16 12:00 ` Peter Korsgaard
@ 2023-06-13 21:47 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2023-06-13 21:47 UTC (permalink / raw)
To: Thomas Devoogdt; +Cc: Adrian Perez de Castro, buildroot
>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:
> Commit 4c7fcbbe75de5c535e8d5dd7182900b6d09e2b03 should have set it to GCC 8.
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-13 21:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 8:01 [Buildroot] [PATCH] package/webkitgtk: fix GCC version in comment Thomas Devoogdt
2023-05-16 11:50 ` Adrian Perez de Castro
2023-05-16 12:00 ` Peter Korsgaard
2023-06-13 21:47 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox