Re: [Buildroot] [PATCH 1/1] package/icu: disable icu-config for host package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Bernd, All,

On 2023-05-16 19:34 +0200, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/6a2/6a2a4ed90c1a829e7b9442aaaaa1cd6e5efd9aab/
> 
> python-pyicu picks up ldflags from host version of icu-config
> ---
> Building PyICU 2.10.2 for ICU 70.1 (max ICU major version supported: 72)
> 
> (running 'icu-config --cxxflags --cppflags')
> Adding CFLAGS="-std=c++11 -I/home/buildroot/autobuild/instance-1/output-1/host/include" from /home/buildroot/autobuild/instance-1/output-1/host/bin/icu-config
> (running 'icu-config --ldflags')
> Adding LFLAGS="-L/home/buildroot/autobuild/instance-1/output-1/host/lib -licui18n -licuuc -licudata" from /home/buildroot/autobuild/instance-1/output-1/host/bin/icu-config
> running build
> ---
> leading to linking errors:
> /home/buildroot/autobuild/instance-1/output-1/host/lib/libicui18n.so: file not recognized: file format not recognized
> 
> The icu-config script was deprecated upstream:
> https://unicode-org.github.io/icu/userguide/icu/howtouseicu.html#notes-on-icu-config
> 
> To fix the build error we do not install the host version anymore:
> ---
> Building PyICU 2.10.2 for ICU 70.1 (max ICU major version supported: 72)
> 
> (running 'icu-config --cxxflags --cppflags')
> Could not configure CFLAGS with icu-config
> (running 'pkg-config --cflags icu-i18n')
> (running 'icu-config --ldflags')
> Could not configure LFLAGS with icu-config
> (running 'pkg-config --libs icu-i18n')
> Adding LFLAGS="-licui18n -L/home/bernd/buildroot/output/per-package/python-pyicu/host/bin/../sh4-buildroot-linux-gnu/sysroot/usr/lib -licuuc -licudata" from /home/bernd/buildroot/output/per-package/python-pyicu/host/bin/pkg-config
> running build
> ---

But that would not fix the build of the host system itself has
icu-config in the PATH (for whatever reason).

I think the proper solution would be to make pyicu fully transition to
using pkg-config, e.g. with a patch like:

    diff --git a/setup.py b/setup.py
    index 176c9ab..961a7e9 100644
    --- a/setup.py
    +++ b/setup.py
    @@ -68,7 +68,7 @@ elif platform.startswith('freebsd'):
     
     CONFIGURE_WITH_ICU_CONFIG = {
         'darwin': False,
    -    'linux': True,
    +    'linux': False,
         'freebsd': False, # not tested
         'win32': False,   # no icu-config
         'sunos5': False,  # not tested

(which is just a cheap way to completely render the icu-config case
totally dead-code, as linux is the only platform where icu-config is
still used in pyicu).

Regards,
Yann E. MORIN.

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/icu/icu.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/icu/icu.mk b/package/icu/icu.mk
> index 8107796ae9..1f1dfea5bf 100644
> --- a/package/icu/icu.mk
> +++ b/package/icu/icu.mk
> @@ -48,6 +48,7 @@ ICU_CONF_ENV += ac_cv_func_strtod_l=no
>  endif
>  
>  HOST_ICU_CONF_OPTS = \
> +	--disable-icu-config \
>  	--disable-samples \
>  	--disable-tests \
>  	--disable-extras \
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot