Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@uclibc.org
Subject: Re: [Buildroot] [PATCH 1/1] package/icu: disable icu-config for host package
Date: Tue, 16 May 2023 22:40:42 +0200	[thread overview]
Message-ID: <20230516204042.GQ2582048@scaer> (raw)
In-Reply-To: <pan$57d23$1814592f$72a94616$524b4e2b@ID-313208.user.individual.net>

Bernd, All,

On 2023-05-16 21:08 +0200, Bernd Kuhls spake thusly:
> Am Tue, 16 May 2023 21:03:56 +0200 schrieb Yann E. MORIN:
> >     diff --git a/setup.py b/setup.py
> >     index 176c9ab..961a7e9 100644
> >     --- a/setup.py
> >     +++ b/setup.py
> >     @@ -68,7 +68,7 @@ elif platform.startswith('freebsd'):
> >      
> >      CONFIGURE_WITH_ICU_CONFIG = {
> >          'darwin': False,
> >     -    'linux': True,
> >     +    'linux': False,
> did you run-time test your proposal?

Nope, it was just a quick analysis to drive you in another direction
which I believe is better.

> During my tests a similar fix was not enough due to https://
> gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L93

Indeed. Then just patch it out too...

If we don't do that, then an icu-config on the host *is* going to cause
an issue, even if that's not our icu-config. So pyicu must be fixed.

And since pyicu already has support for using pkg-config, then let's
just ensure it uses that instead of icu-config.

And of-sourse, that means pyicu needs to gain a dependency on
host-pkgconf...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-05-16 20:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 17:34 [Buildroot] [PATCH 1/1] package/icu: disable icu-config for host package Bernd Kuhls
2023-05-16 19:03 ` Yann E. MORIN
     [not found] ` <20230516190356.GP2582048__25958.2416781754$1684263867$gmane$org@scaer>
2023-05-16 19:08   ` Bernd Kuhls
2023-05-16 20:40     ` Yann E. MORIN [this message]
2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/icu: disable icu config Thomas Devoogdt
2026-01-01 16:53   ` Thomas Petazzoni via buildroot
2026-01-03 11:07     ` [Buildroot] [PATCH v2] package/icu: disable icu-config Thomas Devoogdt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516204042.GQ2582048@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@uclibc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox