Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build
Date: Sat, 1 Jul 2023 23:01:34 +0200	[thread overview]
Message-ID: <20230701230134.6c2314e4@windsurf> (raw)
In-Reply-To: <20230613202530.612061-1-bernd.kuhls@t-online.de>

Hello Bernd,

On Tue, 13 Jun 2023 22:25:30 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/
> 
> Set environment variables to cross-compile friendly values, this prevents
> icu-config picking up host libraries:
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216
> 
> This follows the upstream build docs:
> https://gitlab.pyicu.org/main/pyicu#building-pyicu
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v3: use environment variables as proposed by the package author
> v2: prefer pkg-config (Yann), as proposed
>     https://patchwork.ozlabs.org/project/buildroot/patch/20230516173411.823978-1-bernd.kuhls@t-online.de/
> 
>  package/python-pyicu/python-pyicu.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/python-pyicu/python-pyicu.mk b/package/python-pyicu/python-pyicu.mk
> index 512b2f857f..427ebbfe52 100644
> --- a/package/python-pyicu/python-pyicu.mk
> +++ b/package/python-pyicu/python-pyicu.mk
> @@ -12,4 +12,11 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
>  PYTHON_PYICU_DEPENDENCIES = icu
>  PYTHON_PYICU_SETUP_TYPE = setuptools
>  
> +PYTHON_PYICU_ENV += \
> +	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
> +	ICU_BASE="$(STAGING_DIR)/usr" \

Could you clarify where this ICU_BASE variable is used?

For the 3 other variables, I can definitely see it in the links you
have in the commit log, but not for ICU_BASE. Am I missing something?

Also, is there some sort of dependency between this patch and the
python-pyicu bump at
http://patchwork.ozlabs.org/project/buildroot/patch/20230611123108.372959-1-bernd.kuhls@t-online.de/
?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-01 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 20:25 [Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build Bernd Kuhls
2023-07-01 21:01 ` Thomas Petazzoni via buildroot [this message]
     [not found] ` <20230701230134.6c2314e4__32130.2583602787$1688245321$gmane$org@windsurf>
2023-07-02 10:25   ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230701230134.6c2314e4@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox