[Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build

[Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/

Set environment variables to cross-compile friendly values, this prevents
icu-config picking up host libraries:
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216

This follows the upstream build docs:
https://gitlab.pyicu.org/main/pyicu#building-pyicu

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v3: use environment variables as proposed by the package author
v2: prefer pkg-config (Yann), as proposed
    https://patchwork.ozlabs.org/project/buildroot/patch/20230516173411.823978-1-bernd.kuhls@t-online.de/

 package/python-pyicu/python-pyicu.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/python-pyicu/python-pyicu.mk b/package/python-pyicu/python-pyicu.mk
index 512b2f857f..427ebbfe52 100644
--- a/package/python-pyicu/python-pyicu.mk
+++ b/package/python-pyicu/python-pyicu.mk
@@ -12,4 +12,11 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
 PYTHON_PYICU_DEPENDENCIES = icu
 PYTHON_PYICU_SETUP_TYPE = setuptools
 
+PYTHON_PYICU_ENV += \
+	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
+	ICU_BASE="$(STAGING_DIR)/usr" \
+	PYICU_CFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --variable=CXXFLAGS`" \
+	PYICU_LFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-L` \
+		`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-l`"
+
 $(eval $(python-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Tue, 13 Jun 2023 22:25:30 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/
> 
> Set environment variables to cross-compile friendly values, this prevents
> icu-config picking up host libraries:
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
> https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216
> 
> This follows the upstream build docs:
> https://gitlab.pyicu.org/main/pyicu#building-pyicu
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v3: use environment variables as proposed by the package author
> v2: prefer pkg-config (Yann), as proposed
>     https://patchwork.ozlabs.org/project/buildroot/patch/20230516173411.823978-1-bernd.kuhls@t-online.de/
> 
>  package/python-pyicu/python-pyicu.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/python-pyicu/python-pyicu.mk b/package/python-pyicu/python-pyicu.mk
> index 512b2f857f..427ebbfe52 100644
> --- a/package/python-pyicu/python-pyicu.mk
> +++ b/package/python-pyicu/python-pyicu.mk
> @@ -12,4 +12,11 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
>  PYTHON_PYICU_DEPENDENCIES = icu
>  PYTHON_PYICU_SETUP_TYPE = setuptools
>  
> +PYTHON_PYICU_ENV += \
> +	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
> +	ICU_BASE="$(STAGING_DIR)/usr" \

Could you clarify where this ICU_BASE variable is used?

For the 3 other variables, I can definitely see it in the links you
have in the commit log, but not for ICU_BASE. Am I missing something?

Also, is there some sort of dependency between this patch and the
python-pyicu bump at
http://patchwork.ozlabs.org/project/buildroot/patch/20230611123108.372959-1-bernd.kuhls@t-online.de/
?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/1] package/python-pyicu: fix build

[Bernd Kuhls]

Am Sat, 1 Jul 2023 23:01:34 +0200 schrieb Thomas Petazzoni via buildroot:

> Also, is there some sort of dependency between this patch and the
> python-pyicu bump at
> http://patchwork.ozlabs.org/project/buildroot/patch/
20230611123108.372959-1-bernd.kuhls-
zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org/

Hi Thomas,

no.

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot