Re: [Buildroot] [PATCH 1/1] package/bluez5_utils: fix AC_CHECK_FILE error

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Yunhao,

On Mon, 10 Jul 2023 21:57:52 +0800
t123yh.xyz@gmail.com wrote:

> From: Yunhao Tian <t123yh.xyz@gmail.com>
> 
> Commit [1] in bluez5 introuduces AC_CHECK_FILE against ell library,
> which produces the following error when configuring:
> 
>   checking for ./ell/ell.h... configure: error: cannot check for file
>   existence when cross compiling
> 
> As this check is not critical in our use case, this patch removes the
> relevant lines in configure.ac and configure to prevent errors.
> 
> [1]:
> https://github.com/bluez/bluez/commit/1106b28be85ac9586d1758839226e163e9030ee2
> 
> Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>

Thanks a lot for this patch. However, I think there are several issues with it:

(1) We don't want to patch both configure and configure.ac, we want to
    patch only configure.ac, and use BLUEZ5_UTILS_AUTORECONF = YES

(2) AC_CHECK_FILE supports a cache variable that should allow to
    preseed the result of the check. So passing
    "ac_cv_file_${srcdir}/ell/ell.h=yes" should work-around the check,
    of course assuming the relevant quoting is added to prevent
    mis-interpretation of ${srcdir} in this context.

(3) Using AC_CHECK_FILE here is really horrible. The bluez5_utils
    configure script should be improved to use pkg-config to detect the
    external ELL library.

I think in Buildroot for now (2) would be acceptable, but (3) would
definitely be a nice contribution to upstream bluez5_utils.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot