Re: [Buildroot] [PATCH 1/1] package/bluez5_utils: fix AC_CHECK_FILE error

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Yunhao,

On Tue, 11 Jul 2023 00:39:38 +0800
Yunhao Tian <t123yh.xyz@gmail.com> wrote:

> > (1) We don't want to patch both configure and configure.ac, we want to
> >     patch only configure.ac, and use BLUEZ5_UTILS_AUTORECONF = YES  
> Understood, thanks for pointing out!
> >
> > (2) AC_CHECK_FILE supports a cache variable that should allow to
> >     preseed the result of the check. So passing
> >     "ac_cv_file_${srcdir}/ell/ell.h=yes" should work-around the check,
> >     of course assuming the relevant quoting is added to prevent
> >     mis-interpretation of ${srcdir} in this context.  
> I don't think this is worth the effort. Source code package of bluez
> already comes
> with internal ell, so it is not necessary to check it in our use case.

Aaah, but then I misunderstood. I thought the issue occurred when using
an external ELL.

Then in that case, the solution is "easier": we should not use the
internal copy of ELL in bluez-utils sources, but we should use the
external one. In Buildroot, whenever possible we try to use external
libraries, to avoid having multiple copies of the same code in the
target, and also to ensure security issues/bugs only need to be fixed
in one place.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot