Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Huth <huth@tuxfamily.org>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/frotz: Add a missing dependency to the Makefile to fix build problems
Date: Mon, 10 Jul 2023 23:27:09 +0200	[thread overview]
Message-ID: <20230710232709.5b8a3eca@windsurf> (raw)
In-Reply-To: <20221015060411.326933-1-huth@tuxfamily.org>

Hello Thomas,

On Sat, 15 Oct 2022 08:04:11 +0200
Thomas Huth <huth@tuxfamily.org> wrote:

> There are currently some build jobs failing where blorblib is built before
> hash.h has been created. This patch should hopefully fix these issues.
> 
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
>  See e.g. here for a failed build:
>  http://autobuild.buildroot.net/results/9cd213ce2d36f797041c7b21044c2b2c223dd546/build-end.log

I believe this kind of issue dates back from when James was testing
with --shuffle=random. So I tried to reproduce locally by doing several
builds of frotz with "make --shuffle=random", and I was not able to
reproduce. I'm not really keen on adding a patch that "hopefully fix
these issues", without being able to reproduce them and confidently say
that the patch fixes the issue.

So for now, I've marked the patch as Rejected, but we can always
revisit that if we get a way of reproducing the issue, and therefore
confirming that the problem no longer occurs thanks to the patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-10 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-15  6:04 [Buildroot] [PATCH] package/frotz: Add a missing dependency to the Makefile to fix build problems Thomas Huth
2023-07-10 21:27 ` Thomas Petazzoni via buildroot [this message]
2023-07-16 18:19   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710232709.5b8a3eca@windsurf \
    --to=buildroot@buildroot.org \
    --cc=huth@tuxfamily.org \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox