Re: [Buildroot] [PATCH] package/frotz: Add a missing dependency to the Makefile to fix build problems

[Thomas Huth <huth@tuxfamily.org>]

Am Mon, 10 Jul 2023 23:27:09 +0200
schrieb Thomas Petazzoni <thomas.petazzoni@bootlin.com>:

> Hello Thomas,
> 
> On Sat, 15 Oct 2022 08:04:11 +0200
> Thomas Huth <huth@tuxfamily.org> wrote:
> 
> > There are currently some build jobs failing where blorblib is built before
> > hash.h has been created. This patch should hopefully fix these issues.
> > 
> > Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> > ---
> >  See e.g. here for a failed build:
> >  http://autobuild.buildroot.net/results/9cd213ce2d36f797041c7b21044c2b2c223dd546/build-end.log  
> 
> I believe this kind of issue dates back from when James was testing
> with --shuffle=random.

Yes, I think that's right. The problem went away automatically after a
while, I guess that happened when the shuffle had been disabled again.

> So I tried to reproduce locally by doing several
> builds of frotz with "make --shuffle=random", and I was not able to
> reproduce. I'm not really keen on adding a patch that "hopefully fix
> these issues", without being able to reproduce them and confidently say
> that the patch fixes the issue.
> 
> So for now, I've marked the patch as Rejected, but we can always
> revisit that if we get a way of reproducing the issue, and therefore
> confirming that the problem no longer occurs thanks to the patch.

That's fine, I was able to get the patch accepted upstream (with a
different commit message):

 https://gitlab.com/DavidGriffith/frotz/-/commit/cdf0ad4aff2d8937034e02e41a5aadcca320ea18

... so it will be included anyway when we update the package to the next
version.

 Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot