Re: [Buildroot] [PATCH 1/1] package/strace: use bundled headers

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2023-06-11 00:02 -0600, James Hilliard spake thusly:
> On Sat, Jun 10, 2023 at 11:46 PM Baruch Siach <baruch@tkos.co.il> wrote:
> > On Sat, Jun 10 2023, James Hilliard wrote:
> > > Details: https://github.com/strace/strace/issues/253

It is much better to *also* provide a little summary about the actual
issue and the suggested fix, so that:

 1. we don't have to go chasing that information when reviewing the
    patch;

 2. we actually keep that information in our tree, in case the remote
    URL disapears (there have already been cases where the repo
    maintainer just deleted everything)

> > Github issue #253 you linked to mentions --enable-bundled as a
> > workaround. Shouldn't we backport upstream commit 8f691206e4aa76
> > instead?
> >   https://github.com/strace/strace/commit/8f691206e4aa769cc99e264f1c15ae6956789f91
> > But then again maybe we do want to hardcode --enable-bundled for
> > consistency?
> Seems bundled may be less likely to break in the future.

This is not very affirmative.

Indeed, from what I unerstood, there was an actual bug in strace's
configure script, and they fixed it with the commit Baruch pointed to.

So the natural expectation is that we do backport the fix, rather than
paper over the issue.

However, in that case, I believe that indeed, using the bundled headers
is the better solution, but for a totally different reason. Indeed,
strace needs the headers of the running kernel, not those that were used
to build the toolchain. The running kernel is often more recent than
the one used in the toolchain, so we do want the most up-to-date
headers.

So, we want to use strace bundled headers for this reason: to have the
most up-to-date headers.

So, could you please mash this up tinto a proper commit log and respin,
please?

Regards,
Yann E. MORIN.

> > >
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > >  package/strace/strace.mk | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> > > index 6514bfe354..9f6b333318 100644
> > > --- a/package/strace/strace.mk
> > > +++ b/package/strace/strace.mk
> > > @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI
> > >  STRACE_LICENSE = LGPL-2.1+
> > >  STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later
> > >  STRACE_CPE_ID_VENDOR = strace_project
> > > -STRACE_CONF_OPTS = --enable-mpers=no
> > > +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no
> > >
> > >  ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
> > >  STRACE_DEPENDENCIES += libunwind
> >
> >
> > --
> >                                                      ~. .~   Tk Open Systems
> > =}------------------------------------------------ooO--U--Ooo------------{=
> >    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot