Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/strace: use bundled headers
Date: Sun, 11 Jun 2023 08:42:13 +0300	[thread overview]
Message-ID: <87wn0atuu1.fsf@tarshish> (raw)
In-Reply-To: <20230610181914.541374-1-james.hilliard1@gmail.com>

Hi James,

On Sat, Jun 10 2023, James Hilliard wrote:

> Details: https://github.com/strace/strace/issues/253
>
> Fixes:
>  - http://autobuild.buildroot.net/results/867/8675aeca53653d9d792182be61a28ea550dc530d

Thanks for following up on this.

Github issue #253 you linked to mentions --enable-bundled as a
workaround. Shouldn't we backport upstream commit 8f691206e4aa76
instead?

  https://github.com/strace/strace/commit/8f691206e4aa769cc99e264f1c15ae6956789f91

But then again maybe we do want to hardcode --enable-bundled for
consistency?

baruch

>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/strace/strace.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> index 6514bfe354..9f6b333318 100644
> --- a/package/strace/strace.mk
> +++ b/package/strace/strace.mk
> @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI
>  STRACE_LICENSE = LGPL-2.1+
>  STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later
>  STRACE_CPE_ID_VENDOR = strace_project
> -STRACE_CONF_OPTS = --enable-mpers=no
> +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no
>  
>  ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
>  STRACE_DEPENDENCIES += libunwind


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-06-11  5:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 18:19 [Buildroot] [PATCH 1/1] package/strace: use bundled headers James Hilliard
2023-06-11  5:42 ` Baruch Siach via buildroot [this message]
2023-06-11  6:02   ` James Hilliard
2023-07-12 19:58     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn0atuu1.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=james.hilliard1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox