* [Buildroot] [PATCH 1/1] package/strace: use bundled headers @ 2023-06-10 18:19 James Hilliard 2023-06-11 5:42 ` Baruch Siach via buildroot 0 siblings, 1 reply; 4+ messages in thread From: James Hilliard @ 2023-06-10 18:19 UTC (permalink / raw) To: buildroot; +Cc: James Hilliard Details: https://github.com/strace/strace/issues/253 Fixes: - http://autobuild.buildroot.net/results/867/8675aeca53653d9d792182be61a28ea550dc530d Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- package/strace/strace.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/strace/strace.mk b/package/strace/strace.mk index 6514bfe354..9f6b333318 100644 --- a/package/strace/strace.mk +++ b/package/strace/strace.mk @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI STRACE_LICENSE = LGPL-2.1+ STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later STRACE_CPE_ID_VENDOR = strace_project -STRACE_CONF_OPTS = --enable-mpers=no +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no ifeq ($(BR2_PACKAGE_LIBUNWIND),y) STRACE_DEPENDENCIES += libunwind -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/strace: use bundled headers 2023-06-10 18:19 [Buildroot] [PATCH 1/1] package/strace: use bundled headers James Hilliard @ 2023-06-11 5:42 ` Baruch Siach via buildroot 2023-06-11 6:02 ` James Hilliard 0 siblings, 1 reply; 4+ messages in thread From: Baruch Siach via buildroot @ 2023-06-11 5:42 UTC (permalink / raw) To: James Hilliard; +Cc: buildroot Hi James, On Sat, Jun 10 2023, James Hilliard wrote: > Details: https://github.com/strace/strace/issues/253 > > Fixes: > - http://autobuild.buildroot.net/results/867/8675aeca53653d9d792182be61a28ea550dc530d Thanks for following up on this. Github issue #253 you linked to mentions --enable-bundled as a workaround. Shouldn't we backport upstream commit 8f691206e4aa76 instead? https://github.com/strace/strace/commit/8f691206e4aa769cc99e264f1c15ae6956789f91 But then again maybe we do want to hardcode --enable-bundled for consistency? baruch > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > --- > package/strace/strace.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/strace/strace.mk b/package/strace/strace.mk > index 6514bfe354..9f6b333318 100644 > --- a/package/strace/strace.mk > +++ b/package/strace/strace.mk > @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI > STRACE_LICENSE = LGPL-2.1+ > STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later > STRACE_CPE_ID_VENDOR = strace_project > -STRACE_CONF_OPTS = --enable-mpers=no > +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no > > ifeq ($(BR2_PACKAGE_LIBUNWIND),y) > STRACE_DEPENDENCIES += libunwind -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/strace: use bundled headers 2023-06-11 5:42 ` Baruch Siach via buildroot @ 2023-06-11 6:02 ` James Hilliard 2023-07-12 19:58 ` Yann E. MORIN 0 siblings, 1 reply; 4+ messages in thread From: James Hilliard @ 2023-06-11 6:02 UTC (permalink / raw) To: Baruch Siach; +Cc: buildroot On Sat, Jun 10, 2023 at 11:46 PM Baruch Siach <baruch@tkos.co.il> wrote: > > Hi James, > > On Sat, Jun 10 2023, James Hilliard wrote: > > > Details: https://github.com/strace/strace/issues/253 > > > > Fixes: > > - http://autobuild.buildroot.net/results/867/8675aeca53653d9d792182be61a28ea550dc530d > > Thanks for following up on this. > > Github issue #253 you linked to mentions --enable-bundled as a > workaround. Shouldn't we backport upstream commit 8f691206e4aa76 > instead? > > https://github.com/strace/strace/commit/8f691206e4aa769cc99e264f1c15ae6956789f91 > > But then again maybe we do want to hardcode --enable-bundled for > consistency? Seems bundled may be less likely to break in the future. > > baruch > > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > --- > > package/strace/strace.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/strace/strace.mk b/package/strace/strace.mk > > index 6514bfe354..9f6b333318 100644 > > --- a/package/strace/strace.mk > > +++ b/package/strace/strace.mk > > @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI > > STRACE_LICENSE = LGPL-2.1+ > > STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later > > STRACE_CPE_ID_VENDOR = strace_project > > -STRACE_CONF_OPTS = --enable-mpers=no > > +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no > > > > ifeq ($(BR2_PACKAGE_LIBUNWIND),y) > > STRACE_DEPENDENCIES += libunwind > > > -- > ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/strace: use bundled headers 2023-06-11 6:02 ` James Hilliard @ 2023-07-12 19:58 ` Yann E. MORIN 0 siblings, 0 replies; 4+ messages in thread From: Yann E. MORIN @ 2023-07-12 19:58 UTC (permalink / raw) To: James Hilliard; +Cc: buildroot James, All, On 2023-06-11 00:02 -0600, James Hilliard spake thusly: > On Sat, Jun 10, 2023 at 11:46 PM Baruch Siach <baruch@tkos.co.il> wrote: > > On Sat, Jun 10 2023, James Hilliard wrote: > > > Details: https://github.com/strace/strace/issues/253 It is much better to *also* provide a little summary about the actual issue and the suggested fix, so that: 1. we don't have to go chasing that information when reviewing the patch; 2. we actually keep that information in our tree, in case the remote URL disapears (there have already been cases where the repo maintainer just deleted everything) > > Github issue #253 you linked to mentions --enable-bundled as a > > workaround. Shouldn't we backport upstream commit 8f691206e4aa76 > > instead? > > https://github.com/strace/strace/commit/8f691206e4aa769cc99e264f1c15ae6956789f91 > > But then again maybe we do want to hardcode --enable-bundled for > > consistency? > Seems bundled may be less likely to break in the future. This is not very affirmative. Indeed, from what I unerstood, there was an actual bug in strace's configure script, and they fixed it with the commit Baruch pointed to. So the natural expectation is that we do backport the fix, rather than paper over the issue. However, in that case, I believe that indeed, using the bundled headers is the better solution, but for a totally different reason. Indeed, strace needs the headers of the running kernel, not those that were used to build the toolchain. The running kernel is often more recent than the one used in the toolchain, so we do want the most up-to-date headers. So, we want to use strace bundled headers for this reason: to have the most up-to-date headers. So, could you please mash this up tinto a proper commit log and respin, please? Regards, Yann E. MORIN. > > > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > > --- > > > package/strace/strace.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/package/strace/strace.mk b/package/strace/strace.mk > > > index 6514bfe354..9f6b333318 100644 > > > --- a/package/strace/strace.mk > > > +++ b/package/strace/strace.mk > > > @@ -10,7 +10,7 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI > > > STRACE_LICENSE = LGPL-2.1+ > > > STRACE_LICENSE_FILES = COPYING LGPL-2.1-or-later > > > STRACE_CPE_ID_VENDOR = strace_project > > > -STRACE_CONF_OPTS = --enable-mpers=no > > > +STRACE_CONF_OPTS = --enable-bundled=yes --enable-mpers=no > > > > > > ifeq ($(BR2_PACKAGE_LIBUNWIND),y) > > > STRACE_DEPENDENCIES += libunwind > > > > > > -- > > ~. .~ Tk Open Systems > > =}------------------------------------------------ooO--U--Ooo------------{= > > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-12 19:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-10 18:19 [Buildroot] [PATCH 1/1] package/strace: use bundled headers James Hilliard 2023-06-11 5:42 ` Baruch Siach via buildroot 2023-06-11 6:02 ` James Hilliard 2023-07-12 19:58 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox