Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] rtl8822cs: new package
@ 2022-11-25 10:26 Viacheslav Bocharov via buildroot
  2023-07-13 21:25 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Bocharov via buildroot @ 2022-11-25 10:26 UTC (permalink / raw)
  To: buildroot, Thomas Petazzoni

This package adds the rtl88822cs WiFi driver.
   repo: https://github.com/jethome-ru/rtl88x2cs.git
   branch: tune_for_jethub

Driver is known to support Realtek RTL8822CS SDIO WiFi/BT chip.

Signed-off-by: Viacheslav Bocharov <adeep@lexina.in>
---
 DEVELOPERS                       |  3 +++
 package/Config.in                |  1 +
 package/rtl8822cs/Config.in      | 12 ++++++++++++
 package/rtl8822cs/rtl8822cs.hash |  1 +
 package/rtl8822cs/rtl8822cs.mk   | 26 ++++++++++++++++++++++++++
 5 files changed, 43 insertions(+)
 create mode 100644 package/rtl8822cs/Config.in
 create mode 100644 package/rtl8822cs/rtl8822cs.hash
 create mode 100644 package/rtl8822cs/rtl8822cs.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 569d58407a..dda837bc5d 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2937,6 +2937,9 @@ F:	package/llvm/
 N:	Vanya Sergeev <vsergeev@gmail.com>
 F:	package/lua-periphery/
 
+N:	Viacheslav Bocharov <adeep@lexina.in>
+F:	package/rtl8822cs/
+
 N:	Victor Huesca <victor.huesca@bootlin.com>
 F:	support/testing/tests/core/test_root_password.py
 
diff --git a/package/Config.in b/package/Config.in
index aef80f9ab0..fc92dc8825 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -584,6 +584,7 @@ endmenu
 	source "package/rtl8723ds/Config.in"
 	source "package/rtl8812au-aircrack-ng/Config.in"
 	source "package/rtl8821au/Config.in"
+	source "package/rtl8822cs/Config.in"
 	source "package/sane-backends/Config.in"
 	source "package/sdparm/Config.in"
 	source "package/sedutil/Config.in"
diff --git a/package/rtl8822cs/Config.in b/package/rtl8822cs/Config.in
new file mode 100644
index 0000000000..c887ae7e02
--- /dev/null
+++ b/package/rtl8822cs/Config.in
@@ -0,0 +1,12 @@
+comment "RTL8822CS needs a Linux kernel to be built"
+	depends on !BR2_s390x
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_RTL8822CS
+	bool "Realtek RTL8822CS SDIO Wi-Fi driver"
+	depends on !BR2_s390x
+	depends on BR2_LINUX_KERNEL
+	help
+          Realtek RTL8822CS Wi-Fi driver as a kernel module (JetHome repository)
+
+          https://github.com/jethome-ru/rtl88x2cs/
diff --git a/package/rtl8822cs/rtl8822cs.hash b/package/rtl8822cs/rtl8822cs.hash
new file mode 100644
index 0000000000..11633e1633
--- /dev/null
+++ b/package/rtl8822cs/rtl8822cs.hash
@@ -0,0 +1 @@
+sha256 4cd97adcf44dc4196fce6f87e68370ad588b19bbc38b246615f9c05739f7bd00  rtl8822cs-db8dc6c7ae1a75af3f6d7fa4f05456c76f5cab3e.tar.gz
diff --git a/package/rtl8822cs/rtl8822cs.mk b/package/rtl8822cs/rtl8822cs.mk
new file mode 100644
index 0000000000..799a07823d
--- /dev/null
+++ b/package/rtl8822cs/rtl8822cs.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# Realtek RTL8822CS driver
+#
+################################################################################
+
+RTL8822CS_VERSION = db8dc6c7ae1a75af3f6d7fa4f05456c76f5cab3e
+RTL8822CS_SITE = $(call github,jethome-ru,rtl88x2cs,$(RTL8822CS_VERSION))
+RTL8822CS_LICENSE = GPL-2.0
+
+RTL8822CS_MODULE_MAKE_OPTS = \
+	CONFIG_RTL8822CS=m \
+	KVER=$(LINUX_VERSION_PROBED) \
+	KSRC=$(LINUX_DIR)
+
+define RTL8822CS_LINUX_CONFIG_FIXUPS
+	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MAC80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+endef
+
+
+$(eval $(kernel-module))
+$(eval $(generic-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH] rtl8822cs: new package
  2022-11-25 10:26 [Buildroot] [PATCH] rtl8822cs: new package Viacheslav Bocharov via buildroot
@ 2023-07-13 21:25 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-13 21:25 UTC (permalink / raw)
  To: Viacheslav Bocharov via buildroot; +Cc: Viacheslav Bocharov

Hello Viacheslav,

On Fri, 25 Nov 2022 13:26:50 +0300
Viacheslav Bocharov via buildroot <buildroot@buildroot.org> wrote:

> This package adds the rtl88822cs WiFi driver.
>    repo: https://github.com/jethome-ru/rtl88x2cs.git
>    branch: tune_for_jethub
> 
> Driver is known to support Realtek RTL8822CS SDIO WiFi/BT chip.
> 
> Signed-off-by: Viacheslav Bocharov <adeep@lexina.in>

Sorry for the super long delay, but good news: I have now applied your
patch! I made some changes, which I will explain below for your
reference.

First, the commit title should have been:

	package/rtl8822cs: new package

> diff --git a/package/rtl8822cs/Config.in b/package/rtl8822cs/Config.in
> new file mode 100644
> index 0000000000..c887ae7e02
> --- /dev/null
> +++ b/package/rtl8822cs/Config.in
> @@ -0,0 +1,12 @@
> +comment "RTL8822CS needs a Linux kernel to be built"

rtl8822cs in lower-case, like the package name.

> +	depends on !BR2_s390x
> +	depends on !BR2_LINUX_KERNEL
> +
> +config BR2_PACKAGE_RTL8822CS
> +	bool "Realtek RTL8822CS SDIO Wi-Fi driver"

Just:

	bool "rtl8822cs"

like the package name.

> +	depends on !BR2_s390x
> +	depends on BR2_LINUX_KERNEL
> +	help
> +          Realtek RTL8822CS Wi-Fi driver as a kernel module (JetHome repository)

Line was slightly too long, so I wrapped it. You can run "make
check-package" to get this kind of sanity checking.

> +
> +          https://github.com/jethome-ru/rtl88x2cs/
> diff --git a/package/rtl8822cs/rtl8822cs.hash b/package/rtl8822cs/rtl8822cs.hash
> new file mode 100644
> index 0000000000..11633e1633
> --- /dev/null
> +++ b/package/rtl8822cs/rtl8822cs.hash
> @@ -0,0 +1 @@
> +sha256 4cd97adcf44dc4196fce6f87e68370ad588b19bbc38b246615f9c05739f7bd00  rtl8822cs-db8dc6c7ae1a75af3f6d7fa4f05456c76f5cab3e.tar.gz

         ^^ we want two spaces as a separator

Also, we want a comment that says where the hash comes from. In this case:

# Locally calculated

> diff --git a/package/rtl8822cs/rtl8822cs.mk b/package/rtl8822cs/rtl8822cs.mk
> new file mode 100644
> index 0000000000..799a07823d
> --- /dev/null
> +++ b/package/rtl8822cs/rtl8822cs.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# Realtek RTL8822CS driver

Just:

# rtl8822cs

(i.e, just the package name)

> +#
> +################################################################################
> +
> +RTL8822CS_VERSION = db8dc6c7ae1a75af3f6d7fa4f05456c76f5cab3e

I updated that to a newer commit that has fixes to build with Linux >= 6.3.

> +RTL8822CS_SITE = $(call github,jethome-ru,rtl88x2cs,$(RTL8822CS_VERSION))
> +RTL8822CS_LICENSE = GPL-2.0

It would be nice to ask the maintainer of this github repo to add a
license file.

> +
> +RTL8822CS_MODULE_MAKE_OPTS = \
> +	CONFIG_RTL8822CS=m \
> +	KVER=$(LINUX_VERSION_PROBED) \
> +	KSRC=$(LINUX_DIR)
> +
> +define RTL8822CS_LINUX_CONFIG_FIXUPS
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_MAC80211)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
> +endef
> +
> +

One too many newline here.

As I said: I fixed all those minor details and applied to our master
branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 21:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-25 10:26 [Buildroot] [PATCH] rtl8822cs: new package Viacheslav Bocharov via buildroot
2023-07-13 21:25 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox