[Buildroot] [PATCH 1/1] package/kodi: add optional dependency to clang

[Buildroot] [PATCH 1/1] package/kodi: add optional dependency to clang

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/kodi/kodi.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 7cbc1df40a..54b7673150 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -93,6 +93,13 @@ KODI_CONF_OPTS += \
 	-DLIBDVDNAV_URL=$(KODI_DL_DIR)/kodi-libdvdnav-$(KODI_LIBDVDNAV_VERSION).tar.gz \
 	-DLIBDVDREAD_URL=$(KODI_DL_DIR)/kodi-libdvdread-$(KODI_LIBDVDREAD_VERSION).tar.gz
 
+ifeq ($(BR2_PACKAGE_CLANG),y)
+KODI_CONF_OPTS += -DCLANG_FORMAT_EXECUTABLE=$(HOST_DIR)/bin/clang-format
+KODI_DEPENDENCIES += clang
+else
+KODI_CONF_OPTS += -DCLANG_FORMAT_EXECUTABLE=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_KODI_RENDER_SYSTEM_GL),y)
 KODI_CONF_OPTS += -DAPP_RENDER_SYSTEM=gl
 KODI_DEPENDENCIES += libgl libglu
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/kodi: add optional dependency to clang

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun, 16 Jul 2023 09:54:38 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> +ifeq ($(BR2_PACKAGE_CLANG),y)
> +KODI_CONF_OPTS += -DCLANG_FORMAT_EXECUTABLE=$(HOST_DIR)/bin/clang-format
> +KODI_DEPENDENCIES += clang

I am not a fan of this, because you are testing whether target clang is
enabled (BR2_PACKAGE_CLANG) and having a dependency on target clang,
while what you need is host-clang.

What does clang-format brings to Kodi feature-wise?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot