[Buildroot] [PATCH] package/python-pysmb: add the missing runtime dependency

[Buildroot] [PATCH] package/python-pysmb: add the missing runtime dependency

[yegorslists--- via buildroot]

From: Yegor Yefremov <yegorslists@googlemail.com>

python-tqdm dependency was introduced in 1.2.9.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python-pysmb/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-pysmb/Config.in b/package/python-pysmb/Config.in
index 61d7c2a03e..bb935dddf1 100644
--- a/package/python-pysmb/Config.in
+++ b/package/python-pysmb/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_PYSMB
 	bool "python-pysmb"
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_PYTHON_PYASN1
+	select BR2_PACKAGE_PYTHON_TQDM
 	help
 	  pysmb is an experimental SMB/CIFS library written in Python.
 	  It implements the client-side SMB/CIFS protocol (SMB1 and
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-pysmb: add the missing runtime dependency

[Thomas Petazzoni via buildroot]

On Mon, 17 Jul 2023 11:17:27 +0200
yegorslists--- via buildroot <buildroot@buildroot.org> wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> python-tqdm dependency was introduced in 1.2.9.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python-pysmb/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks. Weird that this dependency was made a
mandatory dependency, it's apparently only used to display some fancy
progress bars... software is getting bloated at a very high speed :/

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-pysmb: add the missing runtime dependency

[Yegor Yefremov via buildroot]

Hi Thomas,

On Tue, Jul 18, 2023 at 11:19 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 17 Jul 2023 11:17:27 +0200
> yegorslists--- via buildroot <buildroot@buildroot.org> wrote:
>
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > python-tqdm dependency was introduced in 1.2.9.
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  package/python-pysmb/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied to master, thanks. Weird that this dependency was made a
> mandatory dependency, it's apparently only used to display some fancy
> progress bars... software is getting bloated at a very high speed :/

I totally agree with you :-( I've sent a test for the pysmb package.

Yegor
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-pysmb: add the missing runtime dependency

[Peter Korsgaard]

>>>>> "yegorslists---" == yegorslists--- via buildroot <buildroot@buildroot.org> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > python-tqdm dependency was introduced in 1.2.9.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot