[Buildroot] [PATCH 1/1] package/opensc: link with -latomic if needed

[Buildroot] [PATCH 1/1] package/opensc: link with -latomic if needed

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/fb4/fb4c6a97ac666a3a75345229a320769df6c0a909/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/opensc/opensc.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
index 253b6b26f8..8944b6c7ed 100644
--- a/package/opensc/opensc.mk
+++ b/package/opensc/opensc.mk
@@ -13,4 +13,8 @@ OPENSC_DEPENDENCIES = openssl pcsc-lite
 OPENSC_INSTALL_STAGING = YES
 OPENSC_CONF_OPTS = --disable-cmocka --disable-strict
 
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+OPENSC_CONF_ENV += LIBS=-latomic
+endif
+
 $(eval $(autotools-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/opensc: link with -latomic if needed

[Thomas Petazzoni via buildroot]

On Thu, 20 Jul 2023 20:54:45 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/fb4/fb4c6a97ac666a3a75345229a320769df6c0a909/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/opensc/opensc.mk | 4 ++++
>  1 file changed, 4 insertions(+)

I continue to think this is not the right way of handling this issue.
opensc is using pkg-config to detect openssl, so it is the openssl .pc
files that should have -latomic. This will fix the issue once for all
for all users of openssl, without chasing them down one by one.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/opensc: link with -latomic if needed

[Bernd Kuhls]

Am Thu, 20 Jul 2023 23:17:17 +0200 schrieb Thomas Petazzoni via buildroot:

> I continue to think this is not the right way of handling this issue.
> opensc is using pkg-config to detect openssl, so it is the openssl .pc
> files that should have -latomic. This will fix the issue once for all
> for all users of openssl, without chasing them down one by one.

Hi Thomas,

openssl has everything in place for statically linking to libatomic:

cat output/per-package/opensc/host/arceb-buildroot-linux-uclibc/sysroot/
usr/lib/pkgconfig/libcrypto.pc | grep atomic

Libs.private: -ldl -pthread -latomic -latomic

It's just the build system of opensc which does not make use of it. Due to 
my limited coding skills I only managed to disable building the test 
binaries which include the broken file:
https://patchwork.ozlabs.org/project/buildroot/patch/
20230724204439.1526127-1-bernd@kuhls.net/

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot