From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk dependencies
Date: Fri, 21 Jul 2023 23:35:31 +0200 [thread overview]
Message-ID: <20230721233531.69a5799c@windsurf> (raw)
In-Reply-To: <20230717122915.3548507-1-bernd@kuhls.net>
On Mon, 17 Jul 2023 14:29:15 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Buildroot commit 80793107a65d95f8dfd0317a726d3a737c78ef67 forgot to add
> packages needed for gtk support:
> https://github.com/transmission/transmission/blob/main/CMakeLists.txt#L40
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/transmission/Config.in | 2 ++
> package/transmission/transmission.mk | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/transmission/Config.in b/package/transmission/Config.in
> index 84bd85eeff..d6567c6452 100644
> --- a/package/transmission/Config.in
> +++ b/package/transmission/Config.in
> @@ -38,6 +38,8 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
> config BR2_PACKAGE_TRANSMISSION_GTK
> bool "transmission-gtk"
> depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS
> + select BR2_PACKAGE_GLIBMM
> + select BR2_PACKAGE_GTKMM3
This option has:
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_nios2
which you did not propagate. There's also tons of other dependencies,
which indeed are not strictly needed as they are already carried by the
top-level transmission option, but if they change, we will forget that
they are also needed because of the dependency on glibmm and gtkmm3.
However, one thing bothers me more than that: you select
BR2_PACKAGE_GLIBMM, but BR2_PACKAGE_GTKMM3 selects
BR2_PACKAGE_GLIBMM2_66, so we will end up with two versions of glibmm.
Are both really used?
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-21 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 12:29 [Buildroot] [PATCH 1/1] package/transmission: fix gtk dependencies Bernd Kuhls
2023-07-21 21:35 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721233531.69a5799c@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox