[Buildroot] [PATCH 1/1] package/transmission: fix gtk dependencies

[Buildroot] [PATCH 1/1] package/transmission: fix gtk dependencies

[Bernd Kuhls]

Buildroot commit 80793107a65d95f8dfd0317a726d3a737c78ef67 forgot to add
packages needed for gtk support:
https://github.com/transmission/transmission/blob/main/CMakeLists.txt#L40

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/transmission/Config.in       | 2 ++
 package/transmission/transmission.mk | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/transmission/Config.in b/package/transmission/Config.in
index 84bd85eeff..d6567c6452 100644
--- a/package/transmission/Config.in
+++ b/package/transmission/Config.in
@@ -38,6 +38,8 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
 config BR2_PACKAGE_TRANSMISSION_GTK
 	bool "transmission-gtk"
 	depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS
+	select BR2_PACKAGE_GLIBMM
+	select BR2_PACKAGE_GTKMM3
 	help
 	  Install transmission GTK-based GUI interface.
 
diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index f3a200ced3..b2d554e742 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -74,7 +74,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
 TRANSMISSION_CONF_OPTS += -DENABLE_GTK=ON
-TRANSMISSION_DEPENDENCIES += libgtk3
+TRANSMISSION_DEPENDENCIES += glibmm gtkmm3 libgtk3
 else
 TRANSMISSION_CONF_OPTS += -DENABLE_GTK=OFF
 endif
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk dependencies

[Thomas Petazzoni via buildroot]

On Mon, 17 Jul 2023 14:29:15 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Buildroot commit 80793107a65d95f8dfd0317a726d3a737c78ef67 forgot to add
> packages needed for gtk support:
> https://github.com/transmission/transmission/blob/main/CMakeLists.txt#L40
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/transmission/Config.in       | 2 ++
>  package/transmission/transmission.mk | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/transmission/Config.in b/package/transmission/Config.in
> index 84bd85eeff..d6567c6452 100644
> --- a/package/transmission/Config.in
> +++ b/package/transmission/Config.in
> @@ -38,6 +38,8 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
>  config BR2_PACKAGE_TRANSMISSION_GTK
>  	bool "transmission-gtk"
>  	depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS
> +	select BR2_PACKAGE_GLIBMM
> +	select BR2_PACKAGE_GTKMM3

This option has:

	depends on BR2_TOOLCHAIN_HAS_SYNC_4
	depends on !BR2_nios2

which you did not propagate. There's also tons of other dependencies,
which indeed are not strictly needed as they are already carried by the
top-level transmission option, but if they change, we will forget that
they are also needed because of the dependency on glibmm and gtkmm3.

However, one thing bothers me more than that: you select
BR2_PACKAGE_GLIBMM, but BR2_PACKAGE_GTKMM3 selects
BR2_PACKAGE_GLIBMM2_66, so we will end up with two versions of glibmm.
Are both really used?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot