From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads
Date: Fri, 28 Jul 2023 21:25:01 +0200 [thread overview]
Message-ID: <20230728212501.7f3b3569@windsurf> (raw)
In-Reply-To: <20230728170648.2838566-1-bernd@kuhls.net>
On Fri, 28 Jul 2023 19:06:48 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/f2b466853ed296fdc8b4629f36e5a6447658f82d/
>
> Quoting the first error message:
> ntp_io.c:3793:9: error: unknown type name 'blocking_child'
>
> ntp needs either fork or threads:
> https://bk.ntp.org/ntp-dev/include/ntp_workimpl.h?PAGE=anno&REV=4d6178063mDeaH-s7PteNqw1DDK-Rw
>
> #if defined(WORK_FORK) || defined(WORK_THREAD)
> # define WORKER
> #endif
>
> to enable the blocking_child code based on the WORKER define:
> https://bk.ntp.org/ntp-dev/include/intreswork.h?PAGE=anno&REV=4d617805zzdW7YeB56-WZ4GbGCcXxw
>
> The build error first occured on April 3rd, 2022:
> http://autobuild.buildroot.net/results/31b/31bfdac8411ebf043a39e3277f6d7b008fe337b0/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/ntp/Config.in | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks. I was wondering if a Config.in comment was
needed, but it's not the usual case, and having neither MMU nor threads
is really a corner case, so fair enough without a Config.in comment.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-28 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:06 [Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads Bernd Kuhls
2023-07-28 19:25 ` Thomas Petazzoni via buildroot [this message]
2023-08-30 11:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728212501.7f3b3569@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox