[Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads

[Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/f2b466853ed296fdc8b4629f36e5a6447658f82d/

Quoting the first error message:
ntp_io.c:3793:9: error: unknown type name 'blocking_child'

ntp needs either fork or threads:
https://bk.ntp.org/ntp-dev/include/ntp_workimpl.h?PAGE=anno&REV=4d6178063mDeaH-s7PteNqw1DDK-Rw

  #if defined(WORK_FORK) || defined(WORK_THREAD)
  # define WORKER
  #endif

to enable the blocking_child code based on the WORKER define:
https://bk.ntp.org/ntp-dev/include/intreswork.h?PAGE=anno&REV=4d617805zzdW7YeB56-WZ4GbGCcXxw

The build error first occured on April 3rd, 2022:
http://autobuild.buildroot.net/results/31b/31bfdac8411ebf043a39e3277f6d7b008fe337b0/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/ntp/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ntp/Config.in b/package/ntp/Config.in
index 97d933b5a8..78f008a4b8 100644
--- a/package/ntp/Config.in
+++ b/package/ntp/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NTP
 	bool "ntp"
+	depends on BR2_USE_MMU || BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBEVENT
 	help
 	  Network Time Protocol suite/programs.
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads

[Thomas Petazzoni via buildroot]

On Fri, 28 Jul 2023 19:06:48 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/f2b466853ed296fdc8b4629f36e5a6447658f82d/
> 
> Quoting the first error message:
> ntp_io.c:3793:9: error: unknown type name 'blocking_child'
> 
> ntp needs either fork or threads:
> https://bk.ntp.org/ntp-dev/include/ntp_workimpl.h?PAGE=anno&REV=4d6178063mDeaH-s7PteNqw1DDK-Rw
> 
>   #if defined(WORK_FORK) || defined(WORK_THREAD)
>   # define WORKER
>   #endif
> 
> to enable the blocking_child code based on the WORKER define:
> https://bk.ntp.org/ntp-dev/include/intreswork.h?PAGE=anno&REV=4d617805zzdW7YeB56-WZ4GbGCcXxw
> 
> The build error first occured on April 3rd, 2022:
> http://autobuild.buildroot.net/results/31b/31bfdac8411ebf043a39e3277f6d7b008fe337b0/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/ntp/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks. I was wondering if a Config.in comment was
needed, but it's not the usual case, and having neither MMU nor threads
is really a corner case, so fair enough without a Config.in comment.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ntp: needs either mmu or threads

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/f2b466853ed296fdc8b4629f36e5a6447658f82d/

 > Quoting the first error message:
 > ntp_io.c:3793:9: error: unknown type name 'blocking_child'

 > ntp needs either fork or threads:
 > https://bk.ntp.org/ntp-dev/include/ntp_workimpl.h?PAGE=anno&REV=4d6178063mDeaH-s7PteNqw1DDK-Rw

 >   #if defined(WORK_FORK) || defined(WORK_THREAD)
 >   # define WORKER
 >   #endif

 > to enable the blocking_child code based on the WORKER define:
 > https://bk.ntp.org/ntp-dev/include/intreswork.h?PAGE=anno&REV=4d617805zzdW7YeB56-WZ4GbGCcXxw

 > The build error first occured on April 3rd, 2022:
 > http://autobuild.buildroot.net/results/31b/31bfdac8411ebf043a39e3277f6d7b008fe337b0/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot