From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: James Knight <james.d.knight@live.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libglib2: bump version to 2.76.4
Date: Fri, 28 Jul 2023 22:15:09 +0200 [thread overview]
Message-ID: <20230728221509.1127286e@windsurf> (raw)
In-Reply-To: <20230726171923.334017-1-bernd@kuhls.net>
Hello Bernd,
On Wed, 26 Jul 2023 19:19:23 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> From: James Knight <james.d.knight@live.com>
>
> - Drop `iconv` option since it was obsolete and dropped [1][2].
> - Ensure `nls` is explicitly configured based on `BR2_SYSTEM_ENABLE_NLS`
> being set.
> - Cleanup configuration and dependency options (ordering, having a
> common variable to share between host/target builds, adding more
> explicit assignment of options).
> - Drop "0002-Fix-error-format-in-gio-gunixconnection.c-part-2" since
> upstream patch was applied in this release.
>
> Fixes:
> - http://autobuild.buildroot.net/results/f8b0e6f818297ce6a0c68e6e9dccc1eb4666cb73/
> - http://autobuild.buildroot.net/results/aa8560b919732ee597b18c3e9b3315fa325ed489/
>
> [1]: https://gitlab.gnome.org/GNOME/glib/-/commit/e71ecc8771a4f13bc6046438ab0845944831b9a6
> [2]: https://gitlab.gnome.org/GNOME/glib/-/commit/24ec80cfb4522d9819dbf5fd117665fef20b6418
These commits don't really say that iconv is no longer used, only that
the option is gone because Meson now checks iconv.
> -ifneq ($(BR2_ENABLE_LOCALE),y)
> -LIBGLIB2_DEPENDENCIES += libiconv
> -endif
Did you do a test build with a BR2_ENABLE_LOCALE disabled configuration?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-28 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:19 [Buildroot] [PATCH 1/1] package/libglib2: bump version to 2.76.4 Bernd Kuhls
2023-07-28 20:15 ` Thomas Petazzoni via buildroot [this message]
[not found] ` <20230728221509.1127286e__5257.07515641756$1690575343$gmane$org@windsurf>
2023-07-30 10:54 ` Bernd Kuhls
2023-07-30 11:27 ` Thomas Petazzoni via buildroot
2023-07-30 12:09 ` Bernd Kuhls
2023-07-30 12:09 ` Bernd Kuhls
2023-08-07 21:54 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728221509.1127286e@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=fontaine.fabrice@gmail.com \
--cc=james.d.knight@live.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox