Re: [Buildroot] [PATCH 1/1] package/libglib2: bump version to 2.76.4

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

On Wed, 26 Jul 2023 19:19:23 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> From: James Knight <james.d.knight@live.com>
> 
> - Drop `iconv` option since it was obsolete and dropped [1][2].

This fix has nothing to do with the version bump. The issue already
exists in 2.76.1 that we have today in Buildroot, so mixing this fix
with a version bump does not make sense.

So I've applied a commit that only fixes the libiconv issue:

  https://gitlab.com/buildroot.org/buildroot/-/commit/ff050de534eed1dab152890d748952fc659882a0

(I hope I didn't screw it up)

No, we will need a new commit on top of that to bump to 2.76.4. When
doing changes in the bump, always wonder if they are related to the
bump or not. If they are not, they should be a separate commit.

> - Ensure `nls` is explicitly configured based on `BR2_SYSTEM_ENABLE_NLS`
>    being set.
> - Cleanup configuration and dependency options (ordering, having a
>    common variable to share between host/target builds, adding more
>    explicit assignment of options).

For example this has nothing to do with the bump, so it should be a
separate commit. Except that neither Yann nor myself find the sharing
of config options in a "common" variable to be relevant, so we'd prefer
not to have this change.

Once again, really important: a bump should do a bump, and *only*
things related to the bump. If something is not related to the bump =>
separate commit.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot