* [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox
@ 2023-05-28 15:31 Dario Binacchi
2023-05-30 7:49 ` Giulio Benetti
2023-07-28 21:01 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Dario Binacchi @ 2023-05-28 15:31 UTC (permalink / raw)
To: buildroot; +Cc: Dario Binacchi, Christophe Priouzeau
Kernel is built without network support, so network utils are useless.
This has a positive impact on the size of busybox and xipImage, making
them smaller.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
.../common/stm32f4xx/busybox.fragment | 21 +++++++++++++++++++
.../common/stm32f4xx/stm32-post-build.sh | 3 +++
configs/stm32f429_disco_xip_defconfig | 1 +
configs/stm32f469_disco_sd_defconfig | 1 +
configs/stm32f469_disco_xip_defconfig | 1 +
5 files changed, 27 insertions(+)
create mode 100644 board/stmicroelectronics/common/stm32f4xx/busybox.fragment
diff --git a/board/stmicroelectronics/common/stm32f4xx/busybox.fragment b/board/stmicroelectronics/common/stm32f4xx/busybox.fragment
new file mode 100644
index 000000000000..d0bf2cb99dbb
--- /dev/null
+++ b/board/stmicroelectronics/common/stm32f4xx/busybox.fragment
@@ -0,0 +1,21 @@
+# CONFIG_FEATURE_HWIB is not set
+# CONFIG_HOSTNAME is not set
+# CONFIG_DNSDOMAINNAME is not set
+# CONFIG_FEATURE_HTTPD_PORT_DEFAULT is not set
+# CONFIG_IFCONFIG is not set
+# CONFIG_FEATURE_IFCONFIG_HW is not set
+# CONFIG_FEATURE_IFCONFIG_BROADCAST_PLUS is not set
+# CONFIG_IFUP is not set
+# CONFIG_IFDOWN is not set
+# CONFIG_IP is not set
+# CONFIG_IPADDR is not set
+# CONFIG_IPLINK is not set
+# CONFIG_IPROUTE is not set
+# CONFIG_NC is not set
+# CONFIG_NETSTAT is not set
+# CONFIG_PING is not set
+# CONFIG_ROUTE is not set
+# CONFIG_TC is not set
+# CONFIG_TELNET is not set
+# CONFIG_WGET is not set
+# CONFIG_UDHCPC is not set
diff --git a/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh b/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
index 2ac9c653c327..4fcce6150071 100755
--- a/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
+++ b/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
@@ -1,4 +1,7 @@
#!/bin/sh
+# Busybox is built without network support
+sed -i '/hostname/d' ${TARGET_DIR}/etc/inittab
+
# Kernel is built without devpts support
sed -i '/^devpts/d' ${TARGET_DIR}/etc/fstab
diff --git a/configs/stm32f429_disco_xip_defconfig b/configs/stm32f429_disco_xip_defconfig
index 5640d9dc4d32..d4e000487a80 100644
--- a/configs/stm32f429_disco_xip_defconfig
+++ b/configs/stm32f429_disco_xip_defconfig
@@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="xipImage"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f429-disco"
BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
+BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
# BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
BR2_TARGET_ROOTFS_INITRAMFS=y
# BR2_TARGET_ROOTFS_TAR is not set
diff --git a/configs/stm32f469_disco_sd_defconfig b/configs/stm32f469_disco_sd_defconfig
index 662ce3b3d068..8b10bc674176 100644
--- a/configs/stm32f469_disco_sd_defconfig
+++ b/configs/stm32f469_disco_sd_defconfig
@@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="zImage"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f469-disco"
BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
+BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
# BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_SIZE="32M"
diff --git a/configs/stm32f469_disco_xip_defconfig b/configs/stm32f469_disco_xip_defconfig
index ae2780556ad1..e362a9985116 100644
--- a/configs/stm32f469_disco_xip_defconfig
+++ b/configs/stm32f469_disco_xip_defconfig
@@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="xipImage"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f469-disco"
BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
+BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
# BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
BR2_TARGET_ROOTFS_INITRAMFS=y
# BR2_TARGET_ROOTFS_TAR is not set
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox
2023-05-28 15:31 [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox Dario Binacchi
@ 2023-05-30 7:49 ` Giulio Benetti
2023-07-28 21:01 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2023-05-30 7:49 UTC (permalink / raw)
To: Dario Binacchi, buildroot; +Cc: Christophe Priouzeau
Hi Dario,
On 28/05/23 17:31, Dario Binacchi wrote:
> Kernel is built without network support, so network utils are useless.
> This has a positive impact on the size of busybox and xipImage, making
> them smaller.
good idea,
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
I've built tested stm32f469_disco_sd_defconfig successfully, so:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiegineering.com>
--
CEO/CTO@Benetti Engineering sas
> ---
> .../common/stm32f4xx/busybox.fragment | 21 +++++++++++++++++++
> .../common/stm32f4xx/stm32-post-build.sh | 3 +++
> configs/stm32f429_disco_xip_defconfig | 1 +
> configs/stm32f469_disco_sd_defconfig | 1 +
> configs/stm32f469_disco_xip_defconfig | 1 +
> 5 files changed, 27 insertions(+)
> create mode 100644 board/stmicroelectronics/common/stm32f4xx/busybox.fragment
>
> diff --git a/board/stmicroelectronics/common/stm32f4xx/busybox.fragment b/board/stmicroelectronics/common/stm32f4xx/busybox.fragment
> new file mode 100644
> index 000000000000..d0bf2cb99dbb
> --- /dev/null
> +++ b/board/stmicroelectronics/common/stm32f4xx/busybox.fragment
> @@ -0,0 +1,21 @@
> +# CONFIG_FEATURE_HWIB is not set
> +# CONFIG_HOSTNAME is not set
> +# CONFIG_DNSDOMAINNAME is not set
> +# CONFIG_FEATURE_HTTPD_PORT_DEFAULT is not set
> +# CONFIG_IFCONFIG is not set
> +# CONFIG_FEATURE_IFCONFIG_HW is not set
> +# CONFIG_FEATURE_IFCONFIG_BROADCAST_PLUS is not set
> +# CONFIG_IFUP is not set
> +# CONFIG_IFDOWN is not set
> +# CONFIG_IP is not set
> +# CONFIG_IPADDR is not set
> +# CONFIG_IPLINK is not set
> +# CONFIG_IPROUTE is not set
> +# CONFIG_NC is not set
> +# CONFIG_NETSTAT is not set
> +# CONFIG_PING is not set
> +# CONFIG_ROUTE is not set
> +# CONFIG_TC is not set
> +# CONFIG_TELNET is not set
> +# CONFIG_WGET is not set
> +# CONFIG_UDHCPC is not set
> diff --git a/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh b/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
> index 2ac9c653c327..4fcce6150071 100755
> --- a/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
> +++ b/board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh
> @@ -1,4 +1,7 @@
> #!/bin/sh
>
> +# Busybox is built without network support
> +sed -i '/hostname/d' ${TARGET_DIR}/etc/inittab
> +
> # Kernel is built without devpts support
> sed -i '/^devpts/d' ${TARGET_DIR}/etc/fstab
> diff --git a/configs/stm32f429_disco_xip_defconfig b/configs/stm32f429_disco_xip_defconfig
> index 5640d9dc4d32..d4e000487a80 100644
> --- a/configs/stm32f429_disco_xip_defconfig
> +++ b/configs/stm32f429_disco_xip_defconfig
> @@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="xipImage"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f429-disco"
> BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
> +BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
> # BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
> BR2_TARGET_ROOTFS_INITRAMFS=y
> # BR2_TARGET_ROOTFS_TAR is not set
> diff --git a/configs/stm32f469_disco_sd_defconfig b/configs/stm32f469_disco_sd_defconfig
> index 662ce3b3d068..8b10bc674176 100644
> --- a/configs/stm32f469_disco_sd_defconfig
> +++ b/configs/stm32f469_disco_sd_defconfig
> @@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="zImage"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f469-disco"
> BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
> +BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
> # BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
> BR2_TARGET_ROOTFS_EXT2=y
> BR2_TARGET_ROOTFS_EXT2_SIZE="32M"
> diff --git a/configs/stm32f469_disco_xip_defconfig b/configs/stm32f469_disco_xip_defconfig
> index ae2780556ad1..e362a9985116 100644
> --- a/configs/stm32f469_disco_xip_defconfig
> +++ b/configs/stm32f469_disco_xip_defconfig
> @@ -14,6 +14,7 @@ BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="xipImage"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32f469-disco"
> BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
> +BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/stmicroelectronics/common/stm32f4xx/busybox.fragment"
> # BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set
> BR2_TARGET_ROOTFS_INITRAMFS=y
> # BR2_TARGET_ROOTFS_TAR is not set
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox
2023-05-28 15:31 [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox Dario Binacchi
2023-05-30 7:49 ` Giulio Benetti
@ 2023-07-28 21:01 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-28 21:01 UTC (permalink / raw)
To: Dario Binacchi; +Cc: Christophe Priouzeau, buildroot
On Sun, 28 May 2023 17:31:56 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> Kernel is built without network support, so network utils are useless.
> This has a positive impact on the size of busybox and xipImage, making
> them smaller.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> .../common/stm32f4xx/busybox.fragment | 21 +++++++++++++++++++
> .../common/stm32f4xx/stm32-post-build.sh | 3 +++
> configs/stm32f429_disco_xip_defconfig | 1 +
> configs/stm32f469_disco_sd_defconfig | 1 +
> configs/stm32f469_disco_xip_defconfig | 1 +
> 5 files changed, 27 insertions(+)
> create mode 100644 board/stmicroelectronics/common/stm32f4xx/busybox.fragment
We normally don't want to have defconfigs with too many tweaks, but I
agree the STM32F4 ones are special due to their low flash/RAM size, so
applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-28 15:31 [Buildroot] [PATCH 1/1] configs/stm32f4xx_defconfig: off network utils from busybox Dario Binacchi
2023-05-30 7:49 ` Giulio Benetti
2023-07-28 21:01 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox